> On May 15, 2015, 6:17 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/config/__init__.py, lines 255-257 > > <https://reviews.apache.org/r/34300/diff/1/?file=961839#file961839line255> > > > > Delete this property entirely rather than return a dummy value? > > Presumably anything accessing still accessing it should AttributeError.
+1, this is something that can be deleted because it only deals with our code and not configs. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34300/#review84010 ----------------------------------------------------------- On May 15, 2015, 5:01 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34300/ > ----------------------------------------------------------- > > (Updated May 15, 2015, 5:01 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > It's possible to define nested refs that can cause the executor to stack > trace, e.g. > {{derp[{{thermos.ports[http]}}]}} is perfectly valid but crashes the executor. > > > Diffs > ----- > > src/main/python/apache/aurora/config/__init__.py > dd2f89014a3da730364b14e01c499ac0f2c288c1 > src/main/python/apache/aurora/config/schema/base.py > a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 > src/main/python/apache/aurora/config/thrift.py > 810febb637d168b07c4aea77984e1d1451a39af2 > src/main/python/apache/aurora/executor/common/task_info.py > d110faf08135d94d9af95ad74613950c56248c09 > src/main/python/apache/thermos/config/dsl.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/main/python/apache/thermos/config/loader.py > d77ab9a52b16e9d65acdb95f01fd251ae8ab2b6e > src/test/python/apache/aurora/client/test_config.py > c56779712b91f621261358aa7ebd6c4fc65446a0 > src/test/python/apache/aurora/config/test_thrift.py > 654c0b5ae82c98db163c7a44301ff6b23e19b211 > src/test/python/apache/aurora/executor/common/test_task_info.py > 102ba531aa6c28f2d74bd0d7f1668e5861e3a6b8 > > Diff: https://reviews.apache.org/r/34300/diff/ > > > Testing > ------- > > Added some regression tests. > > > Thanks, > > Brian Wickman > >
