> On June 10, 2015, 7:10 p.m., Aurora ReviewBot wrote: > > Master (fab6637) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Using cached twitter.common.process-0.3.0.tar.gz > > Collecting twitter.common.log==0.3.0 (from > > twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) > > Using cached twitter.common.log-0.3.0.tar.gz > > Collecting twitter.common.util==0.3.0 (from > > twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) > > Using cached twitter.common.util-0.3.0.tar.gz > > Collecting twitter.common.collections==0.3.0 (from > > twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) > > Using cached twitter.common.collections-0.3.0.tar.gz > > Collecting smmap>=0.8.5 (from > > gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0) > > Using cached smmap-0.9.0.tar.gz > > Collecting twitter.common.string==0.3.0 (from > > twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) > > Using cached twitter.common.string-0.3.0.tar.gz > > Collecting twitter.common.options==0.3.0 (from > > twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) > > Using cached twitter.common.options-0.3.0.tar.gz > > Collecting twitter.common.dirutil==0.3.0 (from > > twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) > > Using cached twitter.common.dirutil-0.3.0.tar.gz > > Collecting twitter.common.contextutil==0.3.0 (from > > twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) > > Using cached twitter.common.contextutil-0.3.0.tar.gz > > Collecting twitter.common.lang==0.3.0 (from > > twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) > > Using cached twitter.common.lang-0.3.0.tar.gz > > Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, > > twitter.common.lang, twitter.common.string, twitter.common.process, > > twitter.common.options, twitter.common.dirutil, twitter.common.log, > > twitter.common.contextutil, twitter.common.util, > > twitter.common.collections, twitter.common.app, twitter.checkstyle > > Running setup.py install for pyflakes > > Running setup.py install for pep8 > > Running setup.py install for smmap > > Running setup.py install for gitdb > > Running setup.py install for GitPython > > Running setup.py install for twitter.common.lang > > Running setup.py install for twitter.common.string > > Running setup.py install for twitter.common.process > > Running setup.py install for twitter.common.options > > Running setup.py install for twitter.common.dirutil > > Running setup.py install for twitter.common.log > > Running setup.py install for twitter.common.contextutil > > Running setup.py install for twitter.common.util > > Running setup.py install for twitter.common.collections > > Running setup.py install for twitter.common.app > > Running setup.py install for twitter.checkstyle > > Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 > > pyflakes-0.7.2 smmap-0.9.0 twitter.checkstyle-0.1.0 > > twitter.common.app-0.3.0 twitter.common.collections-0.3.0 > > twitter.common.contextutil-0.3.0 twitter.common.dirutil-0.3.0 > > twitter.common.lang-0.3.0 twitter.common.log-0.3.0 > > twitter.common.options-0.3.0 twitter.common.process-0.3.0 > > twitter.common.string-0.3.0 twitter.common.util-0.3.0 > > T200:ERROR > > src/main/python/apache/aurora/executor/thermos_task_runner.py:122 Line has > > trailing whitespace. > > | self._task.graceful_shutdown_endpoint().get(), > > > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry"
@ReviewBot retry - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32973/#review87442 ----------------------------------------------------------- On June 11, 2015, 10:09 a.m., Brian Brazil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32973/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 10:09 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-1257 > https://issues.apache.org/jira/browse/AURORA-1257 > > > Repository: aurora > > > Description > ------- > > Fix name of test for sigterm being ignored. > > Based on > https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34 > > > Diffs > ----- > > docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e > src/main/python/apache/aurora/common/http_signaler.py > 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a > src/main/python/apache/aurora/executor/thermos_task_runner.py > 837ad5c55b4a02215a8d509c211e80529536f705 > src/main/python/apache/thermos/config/schema_base.py > f9143cc1b83143d6147f59d90c79435d055d0518 > src/test/python/apache/aurora/common/test_http_signaler.py > c6a21708eb997f213f4cca038891a84f6c5218d4 > src/test/python/apache/aurora/executor/test_thermos_task_runner.py > 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf > > Diff: https://reviews.apache.org/r/32973/diff/ > > > Testing > ------- > > Unittests and manually in vagrant cluster. Also verified that the flaky tests > pass. > > > Thanks, > > Brian Brazil > >
