----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88042 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java (line 57) <https://reviews.apache.org/r/35498/#comment140448> I could change the command line to take a list of SLA statistic enums to enable. This should help to greatly reduce the overall boilerplate. What do you think? src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java (line 65) <https://reviews.apache.org/r/35498/#comment140450> Using a list of enums instead of serveral bools will also help to simplify this code. - Stephan Erb On June 16, 2015, 11 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35498/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 11 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Compute SLA stats for non-prod jobs > > This is a first iteration closely following the design proposal of Maxim as > posted on the mailinglist. Feedback welcome. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java > 82f36d5ca15df18bdc8ebbbd868d3394db38e603 > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java > ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > 64e986fb2e0f955dd4a9c7824eac9494728bf24e > src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java > cb98834e925793fc116814371548a30470830164 > src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java > 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d > > Diff: https://reviews.apache.org/r/35498/diff/ > > > Testing > ------- > > `./gradlew -Pq build` and a manual verification in Vagrant. > > > Thanks, > > Stephan Erb > >
