----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36357/#review91136 -----------------------------------------------------------
Ship it! Master (8efcd06) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 9, 2015, 5:59 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36357/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 5:59 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1386 > https://issues.apache.org/jira/browse/AURORA-1386 > > > Repository: aurora > > > Description > ------- > > See h2 docs [1] for context on this setting. > > The patch in `DbModule` could have been much smaller, but i did a mini > refactor to supply a map of args to centralize concatenation and make for > easier commenting on each arg. > > [1] http://www.h2database.com/html/advanced.html#transaction_isolation > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 23bf0acf33b7a130bec98e33259bde1b3dc5c7cb > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > c8a2d81bfc48ee8d9cb81aecea1baba920b2b948 > > Diff: https://reviews.apache.org/r/36357/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
