-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review92192
-----------------------------------------------------------


This patch does not apply cleanly on master (4eaacf7), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 18, 2015, 11:36 p.m., Mauricio Garavaglia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 11:36 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -----
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   build-support/packaging/rpm/Makefile PRE-CREATION 
>   build-support/packaging/rpm/README.md PRE-CREATION 
>   build-support/packaging/rpm/aurora.init.sh PRE-CREATION 
>   build-support/packaging/rpm/aurora.service PRE-CREATION 
>   build-support/packaging/rpm/aurora.spec PRE-CREATION 
>   build-support/packaging/rpm/aurora.startup.sh PRE-CREATION 
>   build-support/packaging/rpm/aurora.sysconfig PRE-CREATION 
>   build-support/packaging/rpm/clusters.json PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.service PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION 
>   build-support/python/isort 44f9659948703c75372cd70643d5631acb116c2e 
>   build-support/python/isort-check 646cbf0bae4ccf8eac044817138ed1a7a59b261b 
>   build.gradle 78159932388046883494dda97b4a86c06772d26d 
>   buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab 
>   config/findbugs/excludeFilter.xml e1c2503e0c6126c098063e0860f36cebbfe567ee 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   config/pmd/custom.xml 8ad62280f69db0fe185be0005225cf2d65d62383 
>   debian/aurora-doc.docs  
>   debian/aurora-doc.examples  
>   debian/aurora-executor.dirs  
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/aurora-executor.links  
>   debian/aurora-executor.thermos.default  
>   debian/aurora-executor.thermos.init  
>   debian/aurora-executor.thermos.upstart  
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.install  
>   debian/aurora-scheduler.links  
>   debian/aurora-scheduler.postinst  
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   debian/aurora-tools.install  
>   debian/aurora-tools.links  
>   debian/changelog  
>   debian/clusters.json  
>   debian/compat  
>   debian/control 260ac8f42f47d604096282585c092e96448beb32 
>   debian/copyright  
>   debian/pants.ini  
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   debian/source/format  
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 
>   docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   docs/vagrant.md 7b796b2d70c9adf4a8b88bda625dcf70fdfb0f73 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   gradle/wrapper/gradle-wrapper.properties 
> e713793f7d63e65ea68e091b959ba6a68352b48f 
>   rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
> d3e1295db9b933b5ab60d6446dfea453c6051795 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
> 3413b0a480073f39bc01a60bc93b211660d9e278 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> 22104e6d005ae6706a06a21ffe4c730b14ecfe53 
>   src/main/java/org/apache/aurora/GuiceUtils.java 
> 5d0af1ebdccd0d0782f0fbc53d046a338c450167 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> 9e1f35a12205065f2f0cc783a49e14384bc4d50a 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> c31446c447c3385a4763b8a516827988e46cc480 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f2ef70ddc5a859811f0e6c2ade62e115639c1654 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> f0dea48b3df69dedf620a55573731ed9451369c3 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
> f5a18338748da7c443b2fd2ec3a72adf75e7387f 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java
>  cd016af5621be76190ead81921096aae837b59c0 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
>  c1114a411c32c25785adc93e594ee8e291025969 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
> 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
> 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 2f428513305e147b1b33fd5868b9ede8ae72ebb8 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b777777b0ebbf303778e528b16ff3db1aa4e76f1 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> df180a4f9dff75a04ae104462c219444ef605d9a 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 770672c85c06aaf4356b3b3580428b0323edb9d3 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> 82d479e142afe798cd84135b981075035d9ca6dc 
>   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
> bd74f892dde65e957f125a17979ee6c582b3043f 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
> ecba276f1882162d9578e0829b2139040876c7d0 
>   src/main/java/org/apache/aurora/scheduler/http/Cron.java 
> fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> a44ea08950b9d4b33503f4cfc6e28a32c619b3c8 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> b4701295922ddad44d9d5c9fa29eb95e195e1604 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> fcf5e4419b9908281858e591c916c586c707c6cd 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 1c2b08de1e2c470d32baeb845ae0e0a7ce2b75aa 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> d735cbc4169dbf3f7fb8dd1c13bf683ddcce548c 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  1e9b1c3b6e256fd994e94ad30d9340d12ce15f99 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
>  b224983159c4979800fa384bbb082adc7b330b4c 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  7425b93f476ca1228a233a56363136f9e586a5e5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> f233d5a181bb1f43fbbfe657dbda2cf975aa6895 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
> 5bf4d9a659942c65290442fdcd4749bda046bfd8 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 7453680af5a518012f9779f82d0349e897c04994 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 64e986fb2e0f955dd4a9c7824eac9494728bf24e 
>   src/main/java/org/apache/aurora/scheduler/state/LockManager.java 
> e8303f914466ebe93518ec2970e1173dc39d9adb 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> 6aa281cb7b07e3e82c578c553eee8c7066cf2761 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> a6d7ab748aeb050f93f817e3b084b03d34a58d9d 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 1b8733bff69aef5a7db6bc7d137932a69717275a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 48d0ff667cf97002795b97c235b9e9e34f8e5018 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> e5c0322007c8d9424b96016c9075790c69cf2cf5 
>   src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 
> 97f9ee81ed18a961e6df4916d9ede1d89f90ded1 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 2be3eb0e9405e3d34533520095423429fe00a2ca 
>   src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 
> 596a3787369616d30a2763a37bcb7b7cc39ad386 
>   src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 
> cceac8ab14243c7806c48cf5a8d4c1175d7004b8 
>   src/main/java/org/apache/aurora/scheduler/storage/db/AttributeMapper.java 
> 3763f4dbd1b83b83c4b19a89784343ef9de100f1 
>   src/main/java/org/apache/aurora/scheduler/storage/db/CronJobMapper.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
> 5f1cd2b7daec40a8a57095e16390698dbb0bcd24 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> 11c9c4ada400d51fc83e9e0de03108456be15fdf 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
> 335d7a95e797fe940e71b10da44cbd97edea69ac 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 2dc3034a5e4389588b5f796ff8dfb06dbc9939b8 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> bb61542f4043847b1c8c92ff1b4a0ecfcfc88973 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 
> 9b30b01e3a9ecdf368910a7270f0d6fed911b2de 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/GarbageCollectedTableMapper.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/InsertResult.java 
> 44dc8f5e3dcc91e80a03d980c5d8ae0db65c8b89 
>   src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java 
> afdaa49d6cd5c135f6e4ddda2b6a45d189560e09 
>   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 
> 5e9ba823d08d2b46342e7722c9df5f2a349c97cf 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> 3ada6286e6ef6e3302802b74eec6c46dd582dc10 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 7ee001f9c019a1e7b669ae5cec6088bf974a3746 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java 
> 8270407f97f44991dcfa47263c4287c58ac558f1 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/shims/ContainerShim.java 
> 07a991d34811256d5ef5504c432fc2b0973ca53f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/shims/TaskConstraintShim.java
>  4990af7ce409eb5de20af1a9535bb30abe39ed45 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/CronCollisionPolicyTypeHandler.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
>  0a519be65f90cb730f6bda1e6d7b019f0f15252b 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/AssignedPort.java 
> 0c6442c90289741aa4c59925a6d7a9e4050bf657 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobConfiguration.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/ScheduledTaskWrapper.java
>  b89e7b5463cdb9ff9d1f9106dda0c0c4908225ca 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/TaskConfigRow.java 
> 0160ae3049db555cae9e3d3705c1f0daaeef53d4 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/TaskLink.java 
> 52b09a905006bed2a9f01b8beb72772273b5630f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
> 12da352a749fe5d974b0cd69eda0b694b0a90bf4 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 
> 35c83b9b8838a00693c8ebc96e496886ca249ed1 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java 
> f9e9e89a52c9bce3dd7e5a727498a7c87c26a56c 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> 4b67f6ba03d299ed3de73bb5ea69d949364835b3 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 41e144b9c08500867bab8854770f778e6a211b19 
>   src/main/java/org/apache/aurora/scheduler/thrift/Responses.java 
> ffca661e20a9aedb2699a9dd64267375283500ac 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  0670b2b4c3817becefb38f0294f111768386817b 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> 3490394731fe46ccd6691530c03d6b6f9b817573 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> d29cbaecdfd9c05214d5ea66f9ff63a06fbffe86 
>   src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java 
> 3893e3dd397aa64252179e83fd38f2f388d406fe 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceAction.java 
> b553f97662119b42835ad646b5d187c5550ee516 
>   
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 
> 3b9919d635af3304960c8d510ffcfe764a692e07 
>   src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 
> 88a25e67baaa04449bc06e43624747b47616e0be 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  dc085879d14395e6de76dfe03fbc296756f5d880 
>   src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java 
> 6815f67ade1446b1ca0d7a13df4ef2d014d59a3f 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
> 927a7d131a385702e25947b6a87170f6302aa983 
>   
> src/main/java/org/apache/aurora/scheduler/updater/strategy/BatchStrategy.java 
> 67d595bd81c2e90178b5b9179974190a8ae17322 
>   src/main/python/apache/aurora/admin/admin.py 
> d2f7bd13ef335bdca7dc02177c031ac36574658d 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> c31e2a6fb0348c5e7074e46d61c2d2723afaf14d 
>   src/main/python/apache/aurora/admin/maintenance.py 
> 27d63f2340b9ee7e66e0f9ba8ce17de529be923b 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 2b8047c70d2d5bbe6d607437e2f4c9ba161e0cab 
>   src/main/python/apache/aurora/client/base.py 
> df53b9036e609726bc2d2e17fe2e66a2e1c7f001 
>   src/main/python/apache/aurora/client/cli/context.py 
> c850223588df9d9be4a644aa51adc6419a751af0 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 5f608419e1235f14836865b46be05d13963deb37 
>   src/main/python/apache/aurora/client/cli/options.py 
> f8ac25287e296bcec89d3701738c7dd06ffae133 
>   src/main/python/apache/aurora/client/cli/sla.py 
> 0274988d31dbe1386e8a62a005a1408a42043e45 
>   src/main/python/apache/aurora/client/cli/task.py 
> b541d03d6e34dce7f4f1e38e2d970c71c8d94e08 
>   src/main/python/apache/aurora/client/cli/update.py 
> 70f6c69aa9226981c66c0f986fd53840c56d210f 
>   src/main/python/apache/aurora/config/__init__.py 
> dd2f89014a3da730364b14e01c499ac0f2c288c1 
>   src/main/python/apache/aurora/config/loader.py 
> c8b045e9a668199feee0ac3cee9fac55fe09cf08 
>   src/main/python/apache/aurora/config/schema/base.py 
> ec9f983564516afe542ab277d987d4d391f87e45 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   src/main/python/apache/aurora/executor/BUILD 
> cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 7ad179e632a164df98109ca7cc3098751533e70d 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 8093717266f8620ebc6ef4c028ac8c87ab8d22be 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> d110faf08135d94d9af95ad74613950c56248c09 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> d4392faf50f8c72f08f951962913248045d7fcb5 
>   src/main/python/apache/aurora/executor/http_lifecycle.py PRE-CREATION 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 7bcd6c42f50665eac2e7f17b84e63f2ea7fb4d4f 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> 7d8f848cc8a6fa9669a8a0377590f05b91985064 
>   src/main/python/apache/thermos/cli/commands/BUILD 
> 1dae8c981bd750807ddd1b6071e232ff2697537d 
>   src/main/python/apache/thermos/cli/commands/gc.py 
> 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0 
>   src/main/python/apache/thermos/cli/main.py 
> f20f612790550b77ee3dc969c37317b014a64972 
>   src/main/python/apache/thermos/config/dsl.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/main/python/apache/thermos/config/loader.py 
> d77ab9a52b16e9d65acdb95f01fd251ae8ab2b6e 
>   src/main/python/apache/thermos/config/schema_base.py 
> a85def9eea25fa01020ca2dda4e9cefe861c4a5f 
>   src/main/python/apache/thermos/config/schema_helpers.py 
> d88792a67928e23297db918cc62b9c7ee5497432 
>   src/main/python/apache/thermos/core/BUILD 
> efb68e84cf547cb9505a8caf5b47be394dee5145 
>   src/main/python/apache/thermos/core/helper.py 
> 8cd32948663a5d5a1e975e1661b78de701710436 
>   src/main/python/apache/thermos/core/inspector.py 
> 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f 
>   src/main/python/apache/thermos/monitoring/BUILD 
> 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f 
>   src/main/python/apache/thermos/monitoring/garbage.py 
> aa5a2729ae6c94b6a270d97425767ccee121e588 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 
> d36b42a22ebf9bbe52e60fea9b8a2677c41bd598 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml 
> f5829ac063272123995193caef5151e0d52d435b 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  8258fb102b7f5fca9635143ebaed542d43abeb9f 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 
> 7c27f374b1143c82131c19448c3236f3dfb96667 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 24cf52680b69e23f5ccbbcada0606975b0405d5b 
>   src/main/resources/scheduler/assets/update.html 
> e95053fdb499cae1c734f955d90f54cffbce68d3 
>   src/test/java/org/apache/aurora/GuavaUtilsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> 63917363f392e6d970fb7e0cb91b840ca5db173e 
>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
> 8476b3409297c50262bfb62142393b3390d2d0c4 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 256ee7700a539575b143cbe8de4803e4c99b000e 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> 126001a90c819f9b3bfd448a060102bcef8b2a35 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 975920af695f1d4590c3e12ab204b55928dfd91a 
>   src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java 
> 1a0f14c0945c2510685d9e2667e3c3ba509f4bbb 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 7dc03b6bbad348c5d8c0efed7e7f61a3764f0755 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c 
>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
> d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  f73b2c69ef99d3296e17703e1685a044c48b8587 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> 0faee9279bc39b7e71f3d4cd12f6b21dcc678356 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 53b21cbb706b110e8b529d34e436f5eeb10b6071 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> f3485414690458bd70c10e5e1ff5b31323c115e8 
>   src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java 
> 5772e15468a578d17e9323b57ceed47a638f2432 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/BiCacheTest.java 
> 47347762b2cdfc3e7d8108d3febe4c8152665059 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java
>  0280a0b54f9a75c72fd079a6ff2b83d966e58a74 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimFilterTest.java
>  67dfb82d1a35e1981e8a90788a3821ea083e5298 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  6ecdbd17898e2df4addd93fe03f536b14a65a638 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java
>  9d3820a72997a03b25701a2d4ac0691a15734a66 
>   src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 
> ec43a44d9cbd0f303e4833953cdb65664d5ed569 
>   src/test/java/org/apache/aurora/scheduler/base/TasksTest.java 
> ed9a2878fece0ffc75b333bdd850d6b59e913a41 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
> b9e16578b27de2985d24c25aae507b3540fcd3ff 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
> 863e9c998c97506759a5526135a33a161a8fb75f 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
>  abb915d722235c889ce4a7dbd10238cf39affb6a 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 
> 2d74b326831fbe22fa6045610ca8d714cd64779e 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> 0e0fabb3d4cb97ad3a33b5904348eceab54778ee 
>   
> src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java 
> 6b360626dbcf96b60e5a408d9d4b605e78d55d56 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  15bb13bf259d1fcd08e51ceda8dcd3e029a9eadd 
>   src/test/java/org/apache/aurora/scheduler/http/H2ConsoleModuleIT.java 
> 9536fe3c484329066d8939edc40fa32525880ef5 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> 703b02698191cbc0e5a911ed6cf4dbfc5de286cf 
>   src/test/java/org/apache/aurora/scheduler/http/LocksTest.java 
> 55fbc55d5218b601472bce979714e33be9f88369 
>   src/test/java/org/apache/aurora/scheduler/http/MnameTest.java 
> cf61dd1eee17c5bb44e96d31452d773165d3cce2 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> f8b134fa1f3fbbd7affef31acb077e7acd4f9761 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java
>  53ba949691768078ac17846b70d1baf440c444d4 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java
>  fda16442b8eb1611cabb77f1c68619dfde1f83f2 
>   src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 
> 5b6e0649ea07136817001eb23fdbdeb6f2a8473e 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> f0f9ac392973a276028aee3e06517a6e6d960bb6 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
>   src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 
> 83eec5d3c8e493fcefbcb5b9cf67dae4e741b095 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java
>  09593b15c9bd711530ddcb5508ed85b58a2ebe02 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java 
> 0724278195bb47cd719f51568f112d533551e042 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> 210bafd5911d03855758a8c2604feb7473176bbe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> 58ee226a3819d6796a169156320c10677e35611a 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> cb98834e925793fc116814371548a30470830164 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  0d54049c822b6f24871745b7be2cf43eeca142f3 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> ff0ef021b3d0d7df5f37d14915a8f783672cde6a 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> 702a01abaab5554319da6e6700b870fe6692fd46 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> b7326a629c471f319b8396aac1046ce8b8e9598c 
>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 
> 7b12d642184e09923dd0a551ad38348cb7f2e2af 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 63a784f843eb7edf9a13c623e5355169c7e8623b 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 5ad0de7c6a648f5eb6408eea7bcd789c25d55f88 
>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
> 09e4208afd5f811bae1531642fef63fd6e0d26bf 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  db508cace922b20a19081a1d918cc082b255cd02 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbCronJobStoreTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  550deae7020d0f547e81188e457e5cf2fe05caef 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
> ecbe1dd1eb1f0de07bea490b076c7a920f08bccb 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java 
> a0bd6e1360ee27c368f8a6f2fd5711d22feca14d 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java
>  0bfb4d4d3272c2da00bd9fe97c9bf9a950e9c89e 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
> b24fef95c98b32d162a8e68fc46349dded492c34 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java 
> dda988d03634f8de582cf2b8ccdeb433c3e3de0c 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollectorTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> d4aaa670341a226ff3e51309843db1f3ff5e3d4e 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> e45594665a29ade8adb4a735ccc176a52e3d49dc 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  c183acfbca0e5b87295730a77868cc37f43d164b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
>  4d447d348606e29ae2536974db98f82fa199a877 
>   
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 
> 2ed748383f269217860b80c831a3521facba83ba 
>   
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java
>  58256afafd12e5de234755969605861891af4daf 
>   
> src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java
>  e5e889a54acf1344b31459abb19b9aff163ba9e9 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 916483b7b0876c671cdc67dc60734804b05b2317 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> 48179b843e3b2d4333230f0a9269f28dcd009a31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4786beaf03ec5c1645b112d391064d545a9a7cb5 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  38ef412a6d29dfef7b305e00cf44522818303965 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 2a2b499905a788eb59f5824bc66b487f91e838f1 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
> 5c853002ca02b1da5b0f7075e49627157abb57e4 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
>  22a15460e4d16d79cb0ea873ad0e826035d9ead8 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
>  793684c93b61db68798f2516926cca18591e1c05 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java
>  dac9af2ebbfe5f645f2e56330f3f0929713b54cf 
>   src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 
> 11283031a2288aee8b41ff3c57e71315de0cd622 
>   src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 
> ddec9e63b48a525780747bcb52f80abe1b200726 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 33dd9f1c77c3778af69e766e3c0b91dfb5d17f46 
>   src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 
> d32b40a9b374eeed280a552508c98efeef460ecb 
>   
> src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java 
> d6e855b879e7909e8ba66c03ed34c845bf978a8f 
>   src/test/python/apache/aurora/admin/test_admin.py 
> 4e34ef14a0d2e536a62163377e36d52696de55a2 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> ddd94667718f89e0a1f01f7798d73acd4a060909 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 22b9f995eaa1deae9f5c5467e0939670c099f438 
>   src/test/python/apache/aurora/client/cli/test_context.py 
> 1a134a2ee7d88d2d12a2bcbc122ed0f447ba997f 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 9f32ca3474ea51529217db29b88911010fa73602 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> da52105b5c77419ff64e15a30a04f997f9216a7e 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 5eae70a3e830b01bfeab523c4dfc840447eb8f80 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> dc67cfeeeada1b226cf0fe237fde33ee0712a8cb 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 22b2ca71254a1d2254cc56095f19b07531212c10 
>   src/test/python/apache/aurora/client/cli/util.py 
> 053c9a56248848478ca2fe6ab2c12e24c3d93c13 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> f92e715ad2eb328170c998989644aba1437ca3cb 
>   src/test/python/apache/aurora/client/test_config.py 
> c56779712b91f621261358aa7ebd6c4fc65446a0 
>   src/test/python/apache/aurora/common/test_pex_version.py 
> 3e6e2844231237f850e4e45cb66eb0cbdbb79029 
>   src/test/python/apache/aurora/common/test_transport.py 
> f307e8dcc90a0d93ec90a90f15844bc5ce0b2c09 
>   src/test/python/apache/aurora/config/test_loader.py 
> 00b6eabadb8f4e40aba1191068e1ca04c78d1ff3 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 654c0b5ae82c98db163c7a44301ff6b23e19b211 
>   src/test/python/apache/aurora/executor/BUILD 
> f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/bin/BUILD 
> 2caab2aec136ede9b51ce3bdd0d139270024ba48 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
> d4c1d572663039eb742f70de1e06d708eb0b769a 
>   
> src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py
>  ec5b3f96b3decfd66c37301e9c2101562bd7f8d3 
>   src/test/python/apache/aurora/executor/common/fixtures.py 
> 37d032beb66a67cfd3cfcea272747a2915a745ff 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f614f2c47893e0e16877c1449cf90ca4237382a0 
>   src/test/python/apache/aurora/executor/common/test_task_info.py 
> 102ba531aa6c28f2d74bd0d7f1668e5861e3a6b8 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 17d359054d1fc33f79a7612162064abd335ccf81 
>   src/test/python/apache/aurora/executor/test_http_lifecycle.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 26b26f452fb7c718e4f99f470211dfe926ebe354 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 3569a6abf84d5144d2e268b0a86c82285ffe2b2b 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
> e485b81dddd96729bebb42ccf6d9d58dbf63a872 
>   src/test/python/apache/thermos/cli/commands/test_import.py 
> 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a 
>   src/test/python/apache/thermos/config/test_schema.py 
> 7e1867485593a8fadacb525c57264778831b24f6 
>   src/test/python/apache/thermos/monitoring/BUILD 
> 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481 
>   src/test/python/apache/thermos/monitoring/test_garbage.py 
> 4309c46a3af5f12c8eb3192e3156348fa7c0db23 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
> 79377c387232269094029314b677afeb21ee46ea 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> -------
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Reply via email to