----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36711/ -----------------------------------------------------------
(Updated July 23, 2015, 12:07 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes ------- rebase Repository: aurora Description ------- Remove all public static com.google.common.base.Functions This change removes all public static Functions and either replaces them with static methods or inlines them (if they could have been replaced by method references). The benefit of this change is that these library functions are now usable as `com.google.common.base.Function`s (in the case of guava methods), `java.util.function.Function`s (in the case of the Java 8 standard library), and directly (by callers that were previously invoking them via `.apply`). This change was almost entirely IDE-driven, with the exception of the direct calls (IntelliJ inlines `Tasks.ASSIGNED_TO_ID.apply(assignedTask)` as `((Function<IAssignedTask, String) IAssignedTask::getId).apply(assignedTask)` rather than `assignedTask.getId()`). Since overloads work now and we generally don't repeat the type in the method name, some names were shortened (for example `Tasks.SCHEDULED_TO_INSTANCE_ID` was renamed to `Tasks#getInstanceId(ScheduledTask)`. I chose to only include `public static` Functions in this review to avoid a diff size explosion. Diffs (updated) ----- src/main/java/org/apache/aurora/Protobufs.java 7f1789531bc7fc83dba6e19b39e74f3333a7232a src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 38d2863632e47e0d08c60c59a5d20222b5ebe66a src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java 47e4d48ab4c82b2770a6817666dbd24c3e387b48 src/main/java/org/apache/aurora/scheduler/base/Tasks.java 52d37e255edbabc9874591b7a4cb3e096ac51ecc src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java ae7458c7ea1bb624d0d10539e2ef9f34a77411de src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 303f05cbec7a7134b39ad1d15af3ee5e7a793e0c src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c91c0ea3933e725e3aee5faeb3309f0deba238e2 src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 2b194e5a761cb193a2b72419db1a1120fb52c9fe src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java f1b075a464368adb73be18f19feb938287921017 src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java e6e76cd1007f06bfa089b7171ef326fe52e492c9 src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 61b8e57b0ee62a706433de9376e81b21af7e9e08 src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java bfc23cd88a2a4ce560568ff28d96d8b78eeb6c9e src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 3f262bf99b4723cba0df05675db5e57976dc7a0f src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 04e506368e4b6360b35ab8843b318891806b1853 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 7dca57490fc521fd7497b991aa8778f68b92b03b src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 42967dff996710d3ec1172f481e1f1fb99a20b03 src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java a1d6c9d6857d2bacfcc7e4719ef2b42b66a9b470 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 441f828da2466288136124f2184aae0d5507848b src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 08844d047e021631e8aad359bcb1a6f698425b90 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 4f453e43e21f170293449853f28be49ba0fcb5f8 src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java ca0c0b56a6cc8f7df782763cdc6ff77447cdd09a src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 36bdc819a57cc59c6b8eff7d9d0261408aa1fc8a src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java fc7c79265aff3520cb875c25cf177ffc2f8e0ec9 src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 0b5530478b6b43b87dbf095a3b4c53dc33eaddcf src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 42c11192649c1f068efa8e118818d4b27273d809 src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 92c970c34ca9dc4f052760e5a3d3770a089d9a67 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 062cce06564c1c0cccee8a772ace8230dcff1fbe src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 722dba4f3dc98efeed7128bfa1f2ae02f4670972 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java ab540a59b2297cec76190f4df10cc816d9e1ea97 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 134cd5429512338d0a464b1f3ffa557ca99d5713 src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java 461c4d0cc26d70f0a03130581da666bf2c561bb0 src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java b964f812d20a9d9473f719c34545ff7e58a65559 src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java a9c6d1db1d153657e7f139d81aceb560108d3de1 src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 55ebcb89e9201f23430dcfae3af006ec1a7732bf src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java 791ec1446c2b4429b0b953e8639319622dd02c51 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java ddabb4c04ef329d372504f2fbef597be004e62f1 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 0d0ee9499476d84e5e6f937f8ce7320185b02a7a Diff: https://reviews.apache.org/r/36711/diff/ Testing ------- ./gradlew -Pq build Thanks, Kevin Sweeney
