----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104471 -----------------------------------------------------------
Ship it! Ship It! - Maxim Khutornenko On Oct. 29, 2015, 8:44 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39670/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 8:44 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1510 > https://issues.apache.org/jira/browse/AURORA-1510 > > > Repository: aurora > > > Description > ------- > > ClusterStateImpl exposes a synchronized multimap which does not have a > thread-safe implementation of `keySet`. This patch revises the `ClusterState` > interface to offer more precise operations and modifies `ClusterStateImpl` to > makes all of these operations thread safe. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java > 42e2ca49b3c5de997cb5363e3518512d0f5a725e > > src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java > a1ac922d471013779710e02c0c9ca9f84b506807 > > Diff: https://reviews.apache.org/r/39670/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > If the approach is good, I can update this with benchmark information. > > > Thanks, > > Zameer Manji > >
