-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39670/
-----------------------------------------------------------
(Updated Oct. 27, 2015, 9:14 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs: AURORA-1510
https://issues.apache.org/jira/browse/AURORA-1510
Repository: aurora
Description (updated)
-------
ClusterStateImpl exposes a synchronized multimap which does not have a
thread-safe implementation of `keySet`. This patch revises the `ClusterState`
interface to offer more precise operations and modifies `ClusterStateImpl` to
makes all of these operations thread safe.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/preemptor/ClusterState.java
ce3bc7e6da3f86625c690e26c28ccef67ed9021a
src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java
42e2ca49b3c5de997cb5363e3518512d0f5a725e
src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java
506176769e172b7e9f4ba05c486fe6ab550fb5c3
src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
49002d03b190b8642b6251f4d1fbd6663ee6becc
Diff: https://reviews.apache.org/r/39670/diff/
Testing
-------
./gradlew build -Pq
If the approach is good, I can update this with benchmark information.
Thanks,
Zameer Manji
