-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/
-----------------------------------------------------------

(Updated Dec. 29, 2015, 2:32 p.m.)


Review request for Aurora, John Sirois and Zameer Manji.


Changes
-------

Applied this treatment to all BUILD files under src/test.
```
$ find src/test/ -name BUILD | wc -l
      21
$ find src/test -name BUILD | xargs grep python_tests | wc -l
      20
```


Summary (updated)
-----------------

Simplify test BUILD files to one target per directory.


Repository: aurora


Description
-------

I'm using this file as a proposed convention for test targets in `BUILD` files. 
 In addition to being less redundant, i find the resulting file much easier to 
understand.  In the past when refactoring, i can find it nightmarish to go back 
and bring all the build targets back into line (often repeating myself with 
imports changed in code).

If this proposal is accepted, i would like to further propose we collapse our 
`BUILD` files into one target for all python tests.

Note that this patch is related to 
https://issues.apache.org/jira/browse/AURORA-959


Diffs (updated)
-----

  src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d 
  src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5 
  src/test/python/apache/aurora/admin/BUILD 
ca05c3f893b3e039d47e3dac6bf63035fd9dcd10 
  src/test/python/apache/aurora/client/BUILD 
c9d7616d3d64e75e9ea3a66661064f6cb5e4e659 
  src/test/python/apache/aurora/client/api/BUILD 
2a55cec51324c18debf10a1da93a74043f288a93 
  src/test/python/apache/aurora/client/cli/BUILD 
6d4d5e9c40c9b3efd9d2b50fed687642c5833673 
  src/test/python/apache/aurora/client/hooks/BUILD 
8d43e433d825eb53b1f0154dfe5bf065f1cc2601 
  src/test/python/apache/aurora/common/BUILD 
7909ab5aadc9515e75a40bae169cd92365ea39b9 
  src/test/python/apache/aurora/common/health_check/BUILD 
98a24810bf24d9048c6d1d6ea0d166ac7f33710a 
  src/test/python/apache/aurora/config/BUILD 
2072422a68519c1a5304d77603c82e6b6d65cde0 
  src/test/python/apache/aurora/executor/BUILD 
d50948a2488180ccae07e515c4cd837897f088ac 
  src/test/python/apache/aurora/executor/bin/BUILD 
ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d 
  src/test/python/apache/aurora/executor/common/BUILD 
025947ee18d3bcef0da946466a107a2c89bf51a9 
  src/test/python/apache/aurora/tools/BUILD 
c6014df89ff59352f12762cc535727acf0d065f7 
  src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa 
  src/test/python/apache/thermos/cli/BUILD 
e6284e38721bdf946e2a5f484accb11e9062fdf4 
  src/test/python/apache/thermos/common/BUILD 
460c82e7dc8f1eb0b78842434ead7081bdec55c2 
  src/test/python/apache/thermos/config/BUILD 
f11b9eea93942ce6a934b51a9d10d46d387d0596 
  src/test/python/apache/thermos/core/BUILD 
93c6e107fbea9e85b1757c152ebc7616ccd96b36 
  src/test/python/apache/thermos/monitoring/BUILD 
514dd6c57c6113800569e1064847fff73d289f76 
  src/test/python/apache/thermos/observer/BUILD 
aec3feb7b0f9ce92445d2c08abd9e4d101f5da20 
  src/test/python/apache/thermos/observer/http/BUILD 
8dc30973997a19c91f04350c8bcc479159b7eeb9 

Diff: https://reviews.apache.org/r/41778/diff/


Testing
-------


Thanks,

Bill Farner

Reply via email to