----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40922/#review112563 -----------------------------------------------------------
Ship it! Master (8706a78) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 4, 2016, 12:25 p.m., Martin Hrabovcin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40922/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 12:25 p.m.) > > > Review request for Aurora and John Sirois. > > > Bugs: AURORA-1548 > https://issues.apache.org/jira/browse/AURORA-1548 > > > Repository: aurora > > > Description > ------- > > This patch will provide way to **optionally** specify running process outputs > destination. Implementation was built on top of > https://reviews.apache.org/r/30695/ > > **What was changed:** > > New `destination` parameter is available on global cluster level and also on > each `Process` level. Possible options are `file` (default), `stream` to > parent process stdout/stderr, `mixed` will split output to files and stream > and finally `none` to discard any logs produced by running process. > > > Diffs > ----- > > NEWS c0c454d > docs/configuration-reference.md cf63cfa > docs/deploying-aurora-scheduler.md c0988e8 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 4e9b027 > src/main/python/apache/aurora/executor/thermos_task_runner.py c019fc9 > src/main/python/apache/thermos/config/schema_base.py 5552108 > src/main/python/apache/thermos/core/process.py 8a181b0 > src/main/python/apache/thermos/core/runner.py 5623dce > src/main/python/apache/thermos/runner/thermos_runner.py 3dacd45 > src/test/python/apache/thermos/core/test_process.py da4c494 > > Diff: https://reviews.apache.org/r/40922/diff/ > > > Testing > ------- > > Unit test coverage is provided for new functionality. > > I did also manual testing with mesos/docker and I made sure that logs are > being written to expected files and also same output gets to docker daemon. > > > Thanks, > > Martin Hrabovcin > >
