----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41895/ -----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora Description ------- This fix to Kerberos initialization that moves away from setting a system property to instead use a ConfigFile object directly. This prevents using the default LoginContext internals and entering into races with other components (notably zookeeper). src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) Diffs ----- src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java 09d8db4cdaa6e9320bc2e8bb455adf16c4ec64f9 Diff: https://reviews.apache.org/r/41895/diff/ Testing ------- I now have `./build-support/jenkins/build.sh` and `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` green locally. Prior to this last fix (see depends-on chain for 2 others), got: ``` org.apache.aurora.scheduler.app.SchedulerIT > testLaunch FAILED java.io.IOException: Could not find a 'Server' entry in this configuration: Server cannot start. at org.apache.zookeeper.server.auth.SaslServerCallbackHandler.<init>(SaslServerCallbackHandler.java:53) at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:96) at org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81) at org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64) ... ``` Thanks, John Sirois
