> On Feb. 3, 2016, 2:08 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java, line > > 275 > > <https://reviews.apache.org/r/43150/diff/1/?file=1231802#file1231802line275> > > > > Consider a bit more DRY - _almost_ like having local functions: > > ```java > > BiConsumer<String, Supplier<? extends Number>> makeGuage = (suffix, > > guage) -> > > statsProvider.makeGauge("db_storage_mybatis_connection_pool_" + > > suffix, guage); > > > > makeGuage.accept("requests", poolState::getRequestCount); > > ... > > ``` > > > > ... or just extract a second helper function.
Second helper function extracted. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43150/#review117683 ----------------------------------------------------------- On Feb. 3, 2016, 2:23 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43150/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 2:23 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Bugs: AURORA-1607 > https://issues.apache.org/jira/browse/AURORA-1607 > > > Repository: aurora > > > Description > ------- > > To better understand the MyBatis connection pool this patch exposes the pool > state via stats. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java > 7674b8af6d18b39153ecdf02015f0970e035e874 > src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java > 3ab95c615b01f3201e3b87089119abf01d71dbb7 > > Diff: https://reviews.apache.org/r/43150/diff/ > > > Testing > ------- > > ./gradlew build -Pq > Checked the metrics in vagrant > > > Thanks, > > Zameer Manji > >
