> On Feb. 3, 2016, 2:19 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java, line 
> > 138
> > <https://reviews.apache.org/r/43150/diff/1/?file=1231802#file1231802line138>
> >
> >     Recommend using statsProvider.untracked() here.
> 
> Zameer Manji wrote:
>     What's the reason for that?
> 
> Maxim Khutornenko wrote:
>     I just see no reason not to :) Unless you want to observe them in 
> /graphview...

Unless your external stats system polls pretty frequently, O(seconds), you 
might actually miss useful activity in these gauges.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43150/#review117687
-----------------------------------------------------------


On Feb. 3, 2016, 2:23 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43150/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 2:23 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1607
>     https://issues.apache.org/jira/browse/AURORA-1607
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> To better understand the MyBatis connection pool this patch exposes the pool 
> state via stats.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> 7674b8af6d18b39153ecdf02015f0970e035e874 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
> 3ab95c615b01f3201e3b87089119abf01d71dbb7 
> 
> Diff: https://reviews.apache.org/r/43150/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> Checked the metrics in vagrant
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to