> On Feb. 10, 2016, 10:39 p.m., Stephan Erb wrote:
> > Stupid question: Will there be another review request implementing instance 
> > removal?
> 
> Maxim Khutornenko wrote:
>     It already exists: `aurora job kill`
> 
> Stephan Erb wrote:
>     I feel like this exposes an inconsistency of the API:
>     
>     * `add` appends some instances, without me ever telling me about which 
> instance IDs have been added.
>     * `kill` forces me to explicitly list the instance IDs I want to remove. 
>     
>     This makes it difficult to undo the addition of instances.
> 
> Maxim Khutornenko wrote:
>     Sorry, just noticed your comment after pushing it to master. I think 
> having this type of assymetry should be expected as killing instances does 
> not bear the same SLA meaning as adding them. In other words, I think killing 
> instances should be a more involved operation than adding them to prevent 
> catastrophic service outages due to misspelled instance count. We already 
> have a `job kill` command that is well vetted against that type of action:
>     1. It does not let you kill the entire instance set
>     2. It requires explicit instance ranges
>     3. It uses batch_size=1 (default)

I see. Tool safety is a valid point.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43373/#review118728
-----------------------------------------------------------


On Feb. 11, 2016, 12:11 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43373/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 12:11 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1258
>     https://issues.apache.org/jira/browse/AURORA-1258
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Taking advantage of the refactored addInstances RPC to add a 'scale out' 
> client command.
> 
> The mitigation of .aurora config file `instances` value mismatch is currently 
> discussed at http://markmail.org/message/5ekpapmxr4vxxcd5 and will be 
> addressed separately.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 63bd649377816c72ef2453d9abb7363637a91680 
>   src/main/python/apache/aurora/client/cli/context.py 
> 24a37ec60a8845b4816d292c49fed814ba0a5854 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 67ab4f01eca911aea041328410c6104b63ff8344 
>   src/main/python/apache/aurora/client/cli/options.py 
> 226397865e54cf4c0a59ecb91b93ddc10967edf7 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 185e57d08aa13b687529fefd7c356f3d50c6af33 
>   src/test/python/apache/aurora/api_util.py 
> 9d44b884e5e67506acaaecda1d9ff02a80cf1567 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 974fc7e5a8ea13020e2c01a2088a8535947f05bc 
>   src/test/python/apache/aurora/client/cli/test_add.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_options.py 
> 21d5888c0a87e07a385159de0b56420086666d9d 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 67517a23535e3f535c3114193a5ae06bf4326515 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> f4b771bc968143845772a0149a943c97c5aaf963 
> 
> Diff: https://reviews.apache.org/r/43373/diff/
> 
> 
> Testing
> -------
> 
> local and manual tests in vagrant
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to