> On Feb. 10, 2016, 11:16 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 474
> > <https://reviews.apache.org/r/43373/diff/4/?file=1239604#file1239604line474>
> >
> >     This might be subject to race conditions, i.e. if anyone else is 
> > messing with the number of instances we'll be waiting for the wrong ones. 
> > Seems like this is a fundamental problem in the API.

The --wait-until has similar level of guarantee as in `aurora job create` 
command, namely it's just a convenience feature. Instances may go up/down, fail 
completely (in case of adhoc task) or stay in PENDING forever. It's up to the 
user to reconcile the expectations. It's a loose guarantee but I believe is 
acceptable in this case, as the follow up call to `add_instances` will fail in 
case of an active job update (due to expicit job lock).


On Feb. 10, 2016, 11:16 p.m., Maxim Khutornenko wrote:
> > Have you thought about adding a sentance to 
> > https://github.com/apache/aurora/blob/master/docs/user-guide.md#task-updates
> >  and https://github.com/apache/aurora/blob/master/docs/client-commands.md?

That's is actually a good point. Let me add some info there and a NEWS entry.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43373/#review118754
-----------------------------------------------------------


On Feb. 10, 2016, 11:11 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43373/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 11:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Bugs: AURORA-1258
>     https://issues.apache.org/jira/browse/AURORA-1258
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Taking advantage of the refactored addInstances RPC to add a 'scale out' 
> client command.
> 
> The mitigation of .aurora config file `instances` value mismatch is currently 
> discussed at http://markmail.org/message/5ekpapmxr4vxxcd5 and will be 
> addressed separately.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 63bd649377816c72ef2453d9abb7363637a91680 
>   src/main/python/apache/aurora/client/cli/context.py 
> 24a37ec60a8845b4816d292c49fed814ba0a5854 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 67ab4f01eca911aea041328410c6104b63ff8344 
>   src/main/python/apache/aurora/client/cli/options.py 
> 226397865e54cf4c0a59ecb91b93ddc10967edf7 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 185e57d08aa13b687529fefd7c356f3d50c6af33 
>   src/test/python/apache/aurora/api_util.py 
> 9d44b884e5e67506acaaecda1d9ff02a80cf1567 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 974fc7e5a8ea13020e2c01a2088a8535947f05bc 
>   src/test/python/apache/aurora/client/cli/test_add.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_options.py 
> 21d5888c0a87e07a385159de0b56420086666d9d 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
> 67517a23535e3f535c3114193a5ae06bf4326515 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> f4b771bc968143845772a0149a943c97c5aaf963 
> 
> Diff: https://reviews.apache.org/r/43373/diff/
> 
> 
> Testing
> -------
> 
> local and manual tests in vagrant
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to