----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43567/#review119199 -----------------------------------------------------------
Master (2b48f22) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 14, 2016, 9:52 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43567/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2016, 9:52 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Closing Deflater/Inflater streams explicitly frees their native memory > instantly. Otherwise, the memory will only be freed once the object finalizer > runs. > > I got the idea from this article > http://www.evanjones.ca/java-native-leak-bug.html. Unfortunately, we cannot > use the Java close-with-resource feature, as `TTransport` in our current > Thrift version does not implement `Closable`. > > > Diffs > ----- > > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > 6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062 > > Diff: https://reviews.apache.org/r/43567/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
