-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45212/#review125020
-----------------------------------------------------------




specs/rpm/aurora.spec (line 100)
<https://reviews.apache.org/r/45212/#comment187772>

    Generally this will need to be a range, ie:
    ```
    Requires:      mesos >= %{MESOS_MIN_VERSION}
    Requires:      mesos <= %{MESOS_MAX_VERSION}
    ```
    
    The mesos deprecation policy was raised in this thread: 
http://markmail.org/message/ykijs5gjtzujxtb4, the upshot being Aurora should be 
able to depend on the current version of mesos its being built against on 
master +/- 1.
    
    Similarly, the [deb control 
file](https://github.com/apache/aurora-packaging/blob/master/specs/debian/control#L21-L24)
 should be using something like `mesos (>= 0.24.0), mesos (<= 0.26.0)` or 
`mesos (>= ${MESOS_MIN_VERSION}), mesos (<= ${MESOS_MAX_VERSION})` in concert 
with a `substvars` file.
    
    I'm going to add a few reviewers for additional opinions - I am probably 
overthinking this.


- John Sirois


On March 23, 2016, 6:47 a.m., Pierre Cheynier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45212/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 6:47 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> We should consider MESOS_VERSION as the minimal requirement to install
> the current Aurora version instead of enforce a specific Mesos version.
> 
> 
> Diffs
> -----
> 
>   specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25 
> 
> Diff: https://reviews.apache.org/r/45212/diff/
> 
> 
> Testing
> -------
> 
> Install Aurora through the RPM built with aurora-packaging on a Mesos 0.27
> running install.
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Reply via email to