-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45193/#review125261
-----------------------------------------------------------
Master (9927231) is red with this patch.
./build-support/jenkins/build.sh
[1m
self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert
hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it
is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m
self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert
hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m
self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=1) #
interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999
== 0.5[0m
[1m[31mE + where 0.5009999999999999 =
<apache.aurora.executor.common.health_checker.HealthChecker object at
0x7fcda9901c10>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174:
AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at
0x7fcda9901250>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7fcda9901250>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7fcda9901250>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7fcda9901250>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at
0x7fcda9901250>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at
0x7fcda9901250>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at
0x7fcda9901250>] Time now: 1.502
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 663 passed, 5 skipped, 1 warnings in
313.43 seconds [0m
FAILURE
15:26:21 07:04 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 24, 2016, 2:52 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45193/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 2:52 p.m.)
>
>
> Review request for Aurora, David Chung, Bill Farner, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Previously, `null` was handled differently from an empty collection in
> task queries. For the Go thrift bindings, this was problematic since
> zero values in Go are useful in almost all cases and in particular in the
> case of maps (used to represent sets). In these cases unset `TaskQuery`
> collection parameters are serialized as empty collections (empty
> maps) instead of `nil` (`null`), leading to the inability to use the
> query API in any natural way.
>
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java
> | 2 +-
> src/main/java/org/apache/aurora/scheduler/base/Query.java
> | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java
> | 2 +-
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
> | 6 ++++--
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml
> | 6 +++---
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
> | 20 +++++++++++++++++---
> 6 files changed, 27 insertions(+), 11 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java
> 8f5bf58b963ae5f76aad7dfa34bae5b9e67d6242
> src/main/java/org/apache/aurora/scheduler/base/Query.java
> ee01eaa4d0230d6bf0909b6460f27a74f03240db
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java
> ac0bb374842741d7ccb7a83c574a90ac156af0f9
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java
> 078dd8b63fdca192c735f9097edd030ee315a021
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java
> 4bf40047e105389ac7139edc449857889d390106
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
> 231a55615abfbb483667f5f8ef71d2709fc16a88
> src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java
> d326d24dd527d084bce1b300f1818d3b1d94c036
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
> 5d246bee1a4dabc563a23c542384205537719f6a
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml
> 684614ffc42dd6778c7675a6c2f81cb72c106c0e
>
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java
> dfe94d3fadc3f5e3322dd5a3a367ad6ef22c2a99
>
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
> e56fed2e6c0cdb47737cf1a9b637c44c5e5b9815
>
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
> 3ba03429748448642571cfe0858278a50148745a
>
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
> 0a7b518578f4fd62c22e3ba52d8beae7958dc9eb
>
> Diff: https://reviews.apache.org/r/45193/diff/
>
>
> Testing
> -------
>
> NB: This change was broken out of https://reviews.apache.org/r/42756/
> since it stands on its own (although its slightly more awkward in the
> mutable thrift world) and the case of the Go Aurora API client forces the
> issue.
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
