----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review125456 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 217) <https://reviews.apache.org/r/45177/#comment188242> Sounds OK as hard coded value for now. src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 218) <https://reviews.apache.org/r/45177/#comment188259> That can lead to non-DNS compatible names. I guess there is nothering that we can really do about it. It's just something consumers have to be aware of. src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 220) <https://reviews.apache.org/r/45177/#comment188247> That sounds like a sane choice, but we could also leave it out for now until there is a proper usecase for it. src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 221) <https://reviews.apache.org/r/45177/#comment188246> I guess this refers to the API version of the task? The Mesos documentation is not clear here. I'd vote to keep it out for now. src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 224) <https://reviews.apache.org/r/45177/#comment188254> We could probably do this via the `Announcer` struct. Unfortunately, the documentation is rather unclear if we should pass L4 or L7 protocol names: https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L1799 However, looks like Marathon is saying this should by only `TCP` or `UDP`: https://github.com/mesosphere/marathon/blob/master/src/main/scala/mesosphere/marathon/state/DiscoveryInfo.scala#L25 Hardcoding this value to `TCP` should therefore probably work for us for now, right? - Stephan Erb On March 22, 2016, 9:10 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45177/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 9:10 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Prototype of setting DiscoveryInfo. > > Disclaimer: this just shows how easy it is to pipe this information, not > seeking to commit the code as is. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > 20cbd419dcb988f2c7ba72c8acbe6fee90d02248 > > Diff: https://reviews.apache.org/r/45177/diff/ > > > Testing > ------- > > Use the vagrant environment to start the example in http_example.aurora, and > observe the following in master's state.json: > > ``` > curl 192.168.33.7:5050/state | jq . | less > .... > "tasks": [ > { > "discovery": { > "environment": "test", > "name": "vagrant.test.http_example.1", > "ports": { > "ports": [ > { > "name": "http", > "number": 31648 > } > ] > }, > "visibility": "CLUSTER" > }, > "executor_id": > "thermos-vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0", > "framework_id": "770e194c-6366-41f2-8a2d-e2c616aa9490-0000", > "id": "vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0", > "name": "vagrant/test/http_example", > "resources": { > "cpus": 0.4, > "disk": 64, > "mem": 32, > "ports": "[31648-31648]" > }, > ... > .... > ``` > > > Thanks, > > Zhitao Li > >
