-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45177/
-----------------------------------------------------------

(Updated March 31, 2016, 7:51 p.m.)


Review request for Aurora.


Changes
-------

Unit test and command line flag switch.


Summary (updated)
-----------------

Setting DiscoveryInfo.


Repository: aurora


Description (updated)
-------

This allows alternative service discovery methodologies to find tasks from 
Aurora (e.g. mesos-dns), especially the dynamic port mapping.


Diffs (updated)
-----

  RELEASE-NOTES.md 34f28a165aae4ae24fa95ef19b4972e088fd63a0 
  examples/vagrant/upstart/aurora-scheduler.conf 
120b89a1dc10a259940cb9527eb2517f19d04471 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 949c299bdbc54f976db994266fb97f3099256f13 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java
 7beea81a1e97f3f2fce215ff3e364919c3aebf6d 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
20cbd419dcb988f2c7ba72c8acbe6fee90d02248 
  src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
16fa2d35cdf7ecdf82dd1ec7739e685ec1ff1aa2 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
5103bd0f43d53079976b0f1596e299f2d91aa860 

Diff: https://reviews.apache.org/r/45177/diff/


Testing (updated)
-------

1. Added unit test;
2. Use the vagrant environment to start the example in http_example.aurora, and 
observe the following in master's state.json:

```
curl 192.168.33.7:5050/state | jq . | less
....
"tasks": [
{
"discovery": {
"environment": "test",
"name": "vagrant.test.http_example.1",
"ports": {
"ports": [
{
"name": "http",
"number": 31648
}
]
},
"visibility": "CLUSTER"
},
"executor_id": 
"thermos-vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
"framework_id": "770e194c-6366-41f2-8a2d-e2c616aa9490-0000",
"id": "vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
"name": "vagrant/test/http_example",
"resources": {
"cpus": 0.4,
"disk": 64,
"mem": 32,
"ports": "[31648-31648]"
},
...
....
```


Thanks,

Zhitao Li

Reply via email to