----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126247 -----------------------------------------------------------
Master (193f17e) is red with this patch. ./build-support/jenkins/build.sh :generateBuildProperties :processResources :classes :jar :startScripts :distTar :distZip :assemble :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:29: error: 'class def modifier' have incorrect indentation level 2, expected level should be 0. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:30: error: 'class def modifier' have incorrect indentation level 2, expected level should be 0. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:32: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:34: error: 'ctor def modifier' have incorrect indentation level 4, expected level should be 2. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:36: error: 'ctor def' child have incorrect indentation level 6, expected level should be 4. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:37: error: 'ctor def rcurly' have incorrect indentation level 4, expected level should be 2. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:49:7: error: 'if' is not followed by whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:51:5: error: '}' at column 5 should be on the same line as the next part of a multi-block statement. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:52:12: error: 'if' is not followed by whitespace. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:54:5: error: '}' at column 5 should be on the same line as the next part of a multi-block statement. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. > Checkstyle rule violations were found. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 36.345 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 31, 2016, 2:35 a.m., Ashwin Murthy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45511/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 2:35 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > AURORA-1493: create ELB-friendly endpoint to detect leading scheduler. The > fix is to add a new endpoint - "/leaderhealth" which returns http status code > 200 (OK) if the instance is the leader. If the instance is not the leader but > a leading exists, returns 500 (Internal server error). If there is no leader > at all, returns 503 (Service unavailable) > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45511/diff/ > > > Testing > ------- > > Added new unit test > > > Thanks, > > Ashwin Murthy > >
