----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127386 -----------------------------------------------------------
Master (ddbb965) is red with this patch. ./build-support/jenkins/build.sh thrift.addInstances(null, INSTANCE_KEY, 1); ^ required: InstanceKey,int found: <null>,InstanceKey,int reason: actual and formal argument lists differ in length /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java:1352: error: method addInstances in interface Iface cannot be applied to given types; assertResponse(LOCK_ERROR, thrift.addInstances(null, INSTANCE_KEY, 1)); ^ required: InstanceKey,int found: <null>,InstanceKey,int reason: actual and formal argument lists differ in length /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java:1371: error: method addInstances in interface Iface cannot be applied to given types; assertResponse(INVALID_REQUEST, thrift.addInstances(null, INSTANCE_KEY, 1)); ^ required: InstanceKey,int found: <null>,InstanceKey,int reason: actual and formal argument lists differ in length /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java:1387: error: method addInstances in interface Iface cannot be applied to given types; assertResponse(INVALID_REQUEST, thrift.addInstances(null, INSTANCE_KEY, 1)); ^ required: InstanceKey,int found: <null>,InstanceKey,int reason: actual and formal argument lists differ in length Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. 7 errors FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileTestJava'. > Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 3 mins 46.437 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 6, 2016, 5:49 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45725/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 5:49 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1595 > https://issues.apache.org/jira/browse/AURORA-1595 > > > Repository: aurora > > > Description > ------- > > Remove AddInstancesConfig parameter from addInstances RPC. > > > Diffs > ----- > > RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc > api/src/main/thrift/org/apache/aurora/gen/api.thrift > 2412490b40f4836ac9e1d01aeb91f0e1e8c17028 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java > d9039c935bb11f218558924609906b4b178711ec > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java > f2959921d77ba4c1407a19fe7c752116cea47e26 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 2b557e2c20127e86114f8277ae5b2954d6c4bc2e > src/test/python/apache/aurora/api_util.py > 1497332d266d00e5ae3b56dbde67539aadcf990d > src/test/python/apache/aurora/client/api/test_scheduler_client.py > 0b14b09c8da5053501917e6b4b502714abc80b71 > > Diff: https://reviews.apache.org/r/45725/diff/ > > > Testing > ------- > > end-to-end tests are green > > > Thanks, > > Bill Farner > >