-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127516
-----------------------------------------------------------
Master (9a93955) is red with this patch.
./build-support/jenkins/build.sh
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert
hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it
is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m
self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert
hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m
self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=1) #
interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999
== 0.5[0m
[1m[31mE + where 0.5009999999999999 =
<apache.aurora.executor.common.health_checker.HealthChecker object at
0x7fa233bf00d0>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174:
AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at
0x7fa233bf0510>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7fa233bf0510>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7fa233bf0510>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7fa233bf0510>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at
0x7fa233bf0510>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at
0x7fa233bf0510>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at
0x7fa233bf0510>] Time now: 1.502
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 664 passed, 5 skipped, 1 warnings in
276.99 seconds [0m
FAILURE
[32m
Waiting for background workers to finish.[0m
23:47:57 05:57 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On April 6, 2016, 10:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 10:31 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> 47ab500dffb0cec208edf9eff4c8298b1e717e8d
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
> b078ef0d77f6f85976483147040a1fbbc33a7f6e
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
> 86088d98deace63b21b4de66ca317634b18e66d1
>
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java
> 73a71287fb62395c57afb9daa5ffd0c750ec5e73
> src/main/python/apache/aurora/client/api/__init__.py
> 294c5909b5d67c1694f38c2fa95d034c940fc056
>
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
> 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
> src/test/python/apache/aurora/api_util.py
> 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
> src/test/python/apache/aurora/client/api/test_api.py
> 0dd4b4105e78a797aedb9b888c476cefbc67d662
> src/test/python/apache/aurora/client/api/test_scheduler_client.py
> bd7c834873386b966dc919a9c18abeffc32c4c69
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>