> On April 8, 2016, 11:20 a.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java, > > line 76 > > <https://reviews.apache.org/r/45902/diff/2/?file=1331376#file1331376line76> > > > > This causes the ordering of `eventTypes` to matter, and appears to > > block forever if the ordering is incorrect.. Is that what you want?
Killed. > On April 8, 2016, 11:20 a.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java, > > line 75 > > <https://reviews.apache.org/r/45902/diff/2/?file=1331376#file1331376line75> > > > > Varargs is a bit funny here - always used with exactly 1 arg. If you > > keep varargs, it would be nice to design the method signature to require at > > least one Yeah - my use was factored away. Killed. > On April 8, 2016, 11:20 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java, > > line 92 > > <https://reviews.apache.org/r/45902/diff/2/?file=1331375#file1331375line92> > > > > ditto Killed. > On April 8, 2016, 11:20 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java, > > line 85 > > <https://reviews.apache.org/r/45902/diff/2/?file=1331375#file1331375line85> > > > > `groupCache` is always non-null Yeah - missed clean-up after refactor. Killed. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127817 ----------------------------------------------------------- On April 7, 2016, 5:07 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45902/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 5:07 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1468 > https://issues.apache.org/jira/browse/AURORA-1468 > > > Repository: aurora > > > Description > ------- > > build.gradle > | 5 ++ > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java > | 94 +++++++++++++++++++++++ > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java > | 205 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 304 insertions(+) > > > Diffs > ----- > > build.gradle ad5ec5c4afe4dd5c2189d0680692a7409f0417a9 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45902/diff/ > > > Testing > ------- > > Locally green: `./gradlew -Pq build`. > > > Thanks, > > John Sirois > >
