----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/#review129214 -----------------------------------------------------------
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 105) <https://reviews.apache.org/r/46290/#comment192670> Please note the security implications here. The user should know that this means the health check will run as root. src/test/python/apache/aurora/executor/common/test_health_checker.py (line 318) <https://reviews.apache.org/r/46290/#comment192671> please check the .mock_calls[] attribute here. Otherwise a typo as as `mock_getpwnam.asssssert_not_called()` will hide any test failures. - Zameer Manji On April 15, 2016, 4:31 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46290/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 4:31 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1666 > https://issues.apache.org/jira/browse/AURORA-1666 > > > Repository: aurora > > > Description > ------- > > adding do-not-demote-health-check-to-role flag to not demote health check > user:group to role > > > Diffs > ----- > > RELEASE-NOTES.md 601d2859c3ca51b30fd15de56f75bd5255a51805 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py > 40a0cd6396a78c591debf5e2be11363ecf496231 > src/main/python/apache/aurora/executor/common/health_checker.py > d8675beb8f16ebdd2d6946367784411fe84a5cfc > src/test/python/apache/aurora/executor/common/test_health_checker.py > 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a > > Diff: https://reviews.apache.org/r/46290/diff/ > > > Testing > ------- > > - end to end tests > - added unit tests > > > Thanks, > > Dmitriy Shirchenko > >