----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131028 -----------------------------------------------------------
src/main/resources/scheduler/assets/js/controllers.js (line 139) <https://reviews.apache.org/r/46803/#comment194967> I am not too keen on having a column for an optional field that will most likely read 'default' for all jobs. Perhaps postpone its introduction until TaskConfig.tier is required? - Maxim Khutornenko On April 28, 2016, 11:09 p.m., Amol Deshmukh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46803/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 11:09 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > AURORA-1458: Add tier into the UI "show config" summary. > > > Diffs > ----- > > src/main/resources/scheduler/assets/configSummary.html > 1af7511de0e8a143c8ea88377aad756b44e3ac30 > src/main/resources/scheduler/assets/js/controllers.js > 84417ebeadfae57d55b9f12e8a985825bd620fc8 > src/main/resources/scheduler/assets/js/services.js > d9ce52065f9573b0aa68a95da7da7c50fb14310a > src/main/resources/scheduler/assets/schedulingDetail.html > eb88c1e6dec7a26643e8b13ffcf8e90df70a67f7 > > Diff: https://reviews.apache.org/r/46803/diff/ > > > Testing > ------- > > Ensured the changes appear in the UI after launching the scheduler using > vagrant. > > > File Attachments > ---------------- > > Jobs by Role > > https://reviews.apache.org/media/uploaded/files/2016/04/28/7cbec002-e213-4c24-92d9-16b45efb839c__Jobs_by_Role.png > Per Job Config Summary > > https://reviews.apache.org/media/uploaded/files/2016/04/28/5b785fa7-1053-4b8b-ba0d-438a9170c756__Per_Job_Config_Summary.png > > > Thanks, > > Amol Deshmukh > >
