-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47261/#review132780
-----------------------------------------------------------
Master (485da81) is red with this patch.
./build-support/jenkins/build.sh
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test
org.apache.aurora.scheduler.mesos.MesosTaskFactoryImplTest >
testExecutorInfoUnchanged FAILED
java.lang.AssertionError at MesosTaskFactoryImplTest.java:179
I0511 23:02:04.962 [ShutdownHook, SchedulerMain:97] Stopping scheduler
services.
1005 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated:
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8854124155443703, but must be greater than 0.89
Branch coverage is 0.7932038834951456, but must be greater than 0.835
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 6 mins 53.171 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On May 11, 2016, 10:35 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47261/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 10:35 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch moves `AcceptedOffer` onto a new resource model.
>
> Not particularly happy with the unchecked suppression but all alternatives
> required handling different mesos resource types outside of the
> `MesosResourceConverter`, which was less than ideal. Happy to consider any
> suggestions here.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/Numbers.java
> 703ca3b707320bbda48fa89c45404093b241e785
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
> ef1b5bc2990035ba359509c861fb44ff27b5b8fe
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java
> 46973b8b641686231b9c4f1807ade56790386041
> src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java
> fce6621bc3fd88a9b891fb464e28bf5da0c3867b
>
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
> f3fe05cadd93e99e2a6f2f644b7f850ce9647d03
> src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java
> 3b38469b4819f9ae232c468df8ba652f25001ad3
> src/main/java/org/apache/aurora/scheduler/resources/ResourceMapper.java
> c8e11a406f8a0d19d4e3abf08ab46c27a4003e38
> src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java
> dea7943d40eef1c31663c506a06b8e933f8e6dd2
> src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java
> 276320ae03f93a5351c9d3648dd35f578f6e4cfe
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java
> 36c5c115e9e7ca0bc0e3b34e4148edf349d1e874
>
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
> d4bb5aa1dcc846f8f4d4d153dd733a9c45537976
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java
> ba597b866275e438a113c58206abbb430cc2a535
>
> Diff: https://reviews.apache.org/r/47261/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
