----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48360/#review136647 -----------------------------------------------------------
This looks great. Just a few language tweaks and it's good to go! docs/operations/configuration.md (line 176) <https://reviews.apache.org/r/48360/#comment201735> "to the resource" docs/operations/configuration.md (line 178) <https://reviews.apache.org/r/48360/#comment201736> s/onto/into the docs/operations/configuration.md (line 179) <https://reviews.apache.org/r/48360/#comment201737> s/resource/resources docs/operations/configuration.md (lines 193 - 195) <https://reviews.apache.org/r/48360/#comment201738> Can you reorder these so it's: host_path, container_path, mode? That'll make reading the descriptions in order easier since the reader won't have to refer to later properties to understand the one they're reading. Also, re: mode, provide example values (either `RW` or `RO`)? docs/operations/configuration.md (line 194) <https://reviews.apache.org/r/48360/#comment201739> s/container/the container Also change host_path to ```host_path``` docs/operations/configuration.md (line 195) <https://reviews.apache.org/r/48360/#comment201740> s/which// s/container/the container docs/operations/configuration.md (line 200) <https://reviews.apache.org/r/48360/#comment201734> Can you surround this block with ``` so it's rendered as code? - Joshua Cohen On June 7, 2016, 11:26 p.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48360/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 11:26 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Adding documentation for using a custom executor configuration. > > > Diffs > ----- > > docs/operations/configuration.md 65cf64a713db87996b92bf8305d1fc565163f106 > > Diff: https://reviews.apache.org/r/48360/diff/ > > > Testing > ------- > > > Thanks, > > Renan DelValle > >
