----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50826/#review144930 -----------------------------------------------------------
Ship it! Looks good to me. Would you mind adding something to RELEASE-NOTES.md about ExecutorInfo.source being deprecated in favor of the source label, and that it will be removed from Mesos in an upcoming release? src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 306) <https://reviews.apache.org/r/50826/#comment211092> We should extract sourceName to a var here just like we do in the test. - Joshua Cohen On Aug. 5, 2016, 1:05 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50826/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2016, 1:05 a.m.) > > > Review request for Aurora, Joshua Cohen and Dmitriy Shirchenko. > > > Bugs: AURORA-1745 > https://issues.apache.org/jira/browse/AURORA-1745 > > > Repository: aurora > > > Description > ------- > > b912e17 stopped populating the source field of the executor. For backwards > compatibility we should continue to populate this field and the `source` > label. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > 34134430063b2d24a4e20d3f91ab899604edaf89 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > 7484e8b159eb65634f7bd8f0aae61b2e1227e662 > > Diff: https://reviews.apache.org/r/50826/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >
