-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/#review147543
-----------------------------------------------------------
Master (bd11b1c) is red with this patch.
./build-support/jenkins/build.sh
Running setup.py bdist_wheel for twitter.common.log: finished with status
'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/26/36/82/e6a6b7ca739262435cecee1cde7950bf60950f1aaa2ce21093
Running setup.py bdist_wheel for cov-core: started
Running setup.py bdist_wheel for cov-core: finished with status 'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/86/e1/c2/9ff8cfe9773ce07003f2c2be096e169af4614c2f634671d49b
Running setup.py bdist_wheel for twitter.common.options: started
Running setup.py bdist_wheel for twitter.common.options: finished with status
'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/60/c2/40/54b323809df9598cc125f02527f93ff743cd9bd979f4a1737d
Successfully built pantsbuild.pants ansicolors setproctitle
twitter.common.collections pathspec twitter.common.dirutil pystache scandir
psutil pywatchman Markdown Pygments docutils twitter.common.confluence coverage
pytest pytest-cov lmdb twitter.common.lang twitter.common.log cov-core
twitter.common.options
Installing collected packages: ansicolors, setproctitle, twitter.common.lang,
twitter.common.collections, six, pathspec, twitter.common.dirutil, requests,
pystache, scandir, psutil, pywatchman, futures, setuptools, pex, Markdown,
Pygments, docutils, twitter.common.options, twitter.common.log,
twitter.common.confluence, monotonic, fasteners, coverage, py, pytest,
cov-core, pytest-cov, lmdb, pantsbuild.pants
Found existing installation: setuptools 21.2.1
Uninstalling setuptools-21.2.1:
Successfully uninstalled setuptools-21.2.1
Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2
cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5
lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10
psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1
pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10
setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7
twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7
twitter.common.lang-0.3.7 twitter.common.log-0.3.7 twitter.common.options-0.3.7
05:00:27 00:00 [main]
(To run a reporting server: ./pants server)
05:00:27 00:00 [setup]
05:00:27 00:00 [parse][32m
Executing tasks in goals: compile[0m
05:00:27 00:00 [compile]
05:00:27 00:00 [compile-prep-command]
05:00:27 00:00 [compile]
05:00:27 00:00 [python-eval]
05:00:27 00:00 [pythonstyle]
05:00:27 00:00 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
F821:ERROR src/main/python/apache/aurora/client/cli/update.py:194 undefined
name 'CLIENT_UPDATE_ID'
| {CLIENT_UPDATE_ID: update_id})
F821:ERROR src/main/python/apache/aurora/client/cli/update.py:230 undefined
name 'CLIENT_UPDATE_ID'
| CLIENT_UPDATE_ID]
FAILURE: 2 Python Style issues found
05:00:46 00:19 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Sept. 1, 2016, 4:14 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51384/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2016, 4:14 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim
> Khutornenko.
>
>
> Bugs: AURORA-1711
> https://issues.apache.org/jira/browse/AURORA-1711
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow custom metadata to be stored with the job updates. This feature
> is to help case the reconciliation on job update request on the clients.
>
> Today when a client's requests are proxied via a middle-man,
> if the middle-man times out before the scheduler responds with success,
> the client is left the only option of retry. In the case of updates,
> since multiple updates are not allowed in parallel, the retries fail,
> with INVALID_REQUEST. Although the original update is already accepted
> by the scheduler and is in-progress.
>
> With this feature, clients can reconcile the job updates,
> - by marking updates them with a unique id in the metadata field
> - scheduler returns the in-progress job update in its response
> - client can match the client-generated ids to reconcile its state.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md d79aaadc197697d09a71c83494a01765d6a983d4
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> c5765b70501c101f0535b4eed94e9948c36808f9
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java
> d2673e6b328cb1e249fbe91d18e0d9e935636eaa
>
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
> a3b04949f1726f110638e4f93ef45947cdb9e7f8
>
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
> 929d021a336c6a3438613c9340c84a1096dc9069
>
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
> 594bb6219294dcc77d48dcad14e2a6f9caa0c534
>
> src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
> PRE-CREATION
> src/main/python/apache/aurora/client/api/__init__.py
> 9149c3018ae58d405f284fcbd4076d251ccc8192
> src/main/python/apache/aurora/client/cli/context.py
> 9cf58396dc266e97f18f761d110e564ac02bb15d
> src/main/python/apache/aurora/client/cli/update.py
> d23243dcf93dd82f66b4c8cc4342bd2c8d2adc79
> src/main/python/apache/aurora/client/hooks/hooked_api.py
> 542f165add0f1d01a782fe6d6089bff3e736fb82
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
> 8563630a179cb6d1e3b0e22c730ccbfe1c9291e2
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
> a40830fd668aa650c22a48cbc757b45aef27e961
>
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
> 08530397ff75081bde6f07f9d53317b5486e0da4
>
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
> a7d1f74acdfe5f58eb822a4d826e920cad53dced
>
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
> 779dc302602ae8842084807ca868a491ea99b676
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
> 04551f17999d742c53dfb1b36286b119b448550e
> src/test/python/apache/aurora/client/cli/test_supdate.py
> 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416
> src/test/python/apache/aurora/client/cli/util.py
> aac9f9c802e4ad1f06cee8cf3f56749760b33af5
>
> Diff: https://reviews.apache.org/r/51384/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./pants test src/test/python/apache/aurora/client/cli:cli
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
