-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51564/#review147631
-----------------------------------------------------------
Master (bd11b1c) is red with this patch.
./build-support/jenkins/build.sh
07:00:38 00:00 [parse][32m
Executing tasks in goals: compile[0m
07:00:38 00:00 [compile]
07:00:38 00:00 [compile-prep-command]
07:00:38 00:00 [compile]
07:00:38 00:00 [python-eval]
07:00:38 00:00 [pythonstyle]
07:00:38 00:00 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
T201:ERROR src/main/python/apache/aurora/executor/common/sandbox.py:221-222
Line has trailing slashes.
| if len(splitted) < 3 or splitted[0] != '%s' % group_name or \
| splitted[2] != '%s' % group_id:
T200:ERROR
src/test/python/apache/aurora/executor/common/test_sandbox.py:280-281 Line has
trailing whitespace.
|@mock.patch('apache.aurora.executor.common.sandbox.' +
| 'FileSystemImageSandbox._verify_group_match_in_taskfs')
T200:ERROR
src/test/python/apache/aurora/executor/common/test_sandbox.py:288-289 Line has
trailing whitespace.
|@mock.patch('apache.aurora.executor.common.sandbox.' +
| 'FileSystemImageSandbox._verify_user_match_in_taskfs')
E501:ERROR
PythonFile(src/test/python/apache/aurora/executor/common/test_sandbox.py):160
line too long (108 > 100 characters)
| mock_check_output.assert_called_with(['chroot',
sandbox._task_fs_root, 'getent', 'group', 'test-group'])
W291:ERROR
PythonFile(src/test/python/apache/aurora/executor/common/test_sandbox.py):280-281
trailing whitespace
|@mock.patch('apache.aurora.executor.common.sandbox.' +
| 'FileSystemImageSandbox._verify_group_match_in_taskfs')
W291:ERROR
PythonFile(src/test/python/apache/aurora/executor/common/test_sandbox.py):288-289
trailing whitespace
|@mock.patch('apache.aurora.executor.common.sandbox.' +
| 'FileSystemImageSandbox._verify_user_match_in_taskfs')
FAILURE: 6 Python Style issues found
07:00:58 00:20 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Sept. 2, 2016, 3:26 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51564/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 3:26 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
>
>
> Bugs: AURORA-1761
> https://issues.apache.org/jira/browse/AURORA-1761
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow E_NAME_IN_USE in useradd/groupadd.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/sandbox.py
> a172691e164cf64792f65f049d698f9758336542
> src/test/python/apache/aurora/executor/common/test_sandbox.py
> 57ab39e2444100c3a689bb0ff745c62f7bc2f1a6
>
> Diff: https://reviews.apache.org/r/51564/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
