Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52479/#review151299
-----------------------------------------------------------



Master (ed72b1b) is red with this patch.
  ./build-support/jenkins/build.sh

                             # Create file stdout for capturing output. We 
can't use StringIO mock
                             # because TestProcess is running fork.
                             with open(os.path.join(td, 'sys_stdout'), 
'w+') as stdout:
                               with open(os.path.join(td, 'sys_stderr'), 
'w+') as stderr:
                                 with mutable_sys():
                                   sys.stdout, sys.stderr = stdout, 
stderr
                         
                                   p = TestProcess('process', 'echo hello 
world; echo >&2 hello stderr', 0,
                                                   taskpath, sandbox, 
logger_destination=LoggerDestination.BOTH)
                                   p.start()
                                   rc = 
wait_for_rc(taskpath.getpath('process_checkpoint'))
                         
                                   assert rc == 0
                                   # Check log files were created in std 
path with correct content
                     >             assert_log_content(taskpath, 'stdout', 
'hello world\n')
                     
                     src/test/python/apache/thermos/core/test_process.py:487: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     taskpath = <apache.thermos.common.path.TaskPath object at 
0x7f3936a47bd0>
                     log_name = 'stdout'
                     expected_content = 'hello world\n'
                     
                         def assert_log_content(taskpath, log_name, 
expected_content):
                           log = 
taskpath.with_filename(log_name).getpath('process_logdir')
                           assert os.path.exists(log)
                           with open(log, 'r') as fp:
                     >       assert fp.read() == expected_content
                     E       assert '' == 'hello world\n'
                     E         + hello world
                     
                     src/test/python/apache/thermos/core/test_process.py:313: 
AssertionError
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      1 failed, 725 passed, 6 skipped, 1 warnings in 
476.49 seconds 
                     
FAILURE


05:55:04 08:54   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 4, 2016, 2:05 a.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52479/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 2:05 a.m.)
> 
> 
> Review request for Aurora, George Sirois, Joshua Cohen, John Sirois, and 
> Brian Wickman.
> 
> 
> Bugs: AURORA-1014
>     https://issues.apache.org/jira/browse/AURORA-1014
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Resolve docker tags to concrete identifiers for DockerContainerizer
> 
> Docker tags are mutable and can point to different different images
> at different points in time. This makes a job launched with a Docker
> image to be mutable across restarts of the job. This breaks Aurora's
> guarantee of job immutability (except via job updates).
> 
> This change introduces a binding helper, that resolves docker name:tag
> to a concrete registry/name@digest identifier. Identifying
> docker images via a content-addressable digest is available via the
> Docker Registry v2, that is a prerequisite for this feature.
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 398338966ba715fae523ee4d12afbba4c0eb6bbb 
>   RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
>   docs/features/containers.md 8af38e3af989351925a4130da1ce7a0f5853f0bf 
>   examples/jobs/hello_docker_engine.aurora 
> 3c830e8f99f07732ae985b0aad114c3346888765 
>   examples/vagrant/provision-dev-cluster.sh 
> 66b99cfbd55ab7becfa9534213cc5ea9bdbb3a74 
>   src/main/python/apache/aurora/config/schema/base.py 
> baea660a6ea9f3f7213f98f8bfdb95d912083ac0 
>   src/test/python/apache/aurora/config/BUILD 
> 52b60409e1de2f69f181a83720ebe1c649b49166 
>   src/test/python/apache/aurora/config/test_base.py 
> b354f0804ce70682e8ecb9fb3a3d8fe736fd1cc5 
>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
> c71fb81490863b44827bf090f6e5a6b28da94b93 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora 
> 4fa387d5184968e456bf4c8388496f0514454cb1 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
> b279b4f679cc6843e99806bcbf57350ba1c9a6e0 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> c93be9b4b4c76186445ae13eb9424bbf9de9b202 
> 
> Diff: https://reviews.apache.org/r/52479/diff/
> 
> 
> Testing
> -------
> 
> build-support/jenkins/build.sh
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>