> On Oct. 11, 2016, 12:16 p.m., Stephan Erb wrote: > > docs/features/containers.md, line 77 > > <https://reviews.apache.org/r/52479/diff/4/?file=1527964#file1527964line77> > > > > either `/vagrant` or `aurora` but not `/aurora` :-)
Fixed. > On Oct. 11, 2016, 12:16 p.m., Stephan Erb wrote: > > examples/jobs/hello_docker_engine.aurora, line 49 > > <https://reviews.apache.org/r/52479/diff/4/?file=1527965#file1527965line49> > > > > This does not match the docs. `Docker(image =` seems to be missing. Getting rid the `DockerHelper.resolve` syntactic sugar. So it will read as `container = Docker(image = '{{docker.image[library/python][2.7]}}')`. > On Oct. 11, 2016, 12:16 p.m., Stephan Erb wrote: > > src/test/python/apache/aurora/config/test_base.py, line 241 > > <https://reviews.apache.org/r/52479/diff/4/?file=1527982#file1527982line241> > > > > Seems to be missing the `Docker(image =` as well. Getting rid the `DockerHelper.resolve` syntactic sugar. So it will read as `container = Docker(image = '{{docker.image[library/python][2.7]}}')`. Changes in this file will be dropped. > On Oct. 11, 2016, 12:16 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/config/schema/base.py, lines 136-144 > > <https://reviews.apache.org/r/52479/diff/4/?file=1527974#file1527974line136> > > > > I feel like we should we should drop this helper and require users to > > use the binding helper directly. Calling a method does not really align to > > the rest of our configuration. Dropping `DockerHelper.resolve` and just relying on the binding helpers. Note: The initial idea was to have 2 methods, `DockerHelper.resolve` that will be used in DockerContainerizer `DockerHelper.resolveTag` that will be used in MesosContainerizer. With this change, the binding helpers are bound to change to, `Docker(image = '{{docker.image[some/repo][some.tag]}}')` and `Mesos(image = DockerImage(name = 'some/repo', digest = '{{docker.digest[some/repo][some.tag]}}'))` respectively. > On Oct. 11, 2016, 12:16 p.m., Stephan Erb wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora, > > line 93 > > <https://reviews.apache.org/r/52479/diff/4/?file=1527984#file1527984line93> > > > > This syntax is deprecated. See > > https://github.com/apache/aurora/blob/master/docs/features/containers.md > > for the current one. (You have used the deprecated syntax in several other > > places as well). Fixed. - Santhosh Kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152179 ----------------------------------------------------------- On Oct. 12, 2016, 6:52 p.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52479/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 6:52 p.m.) > > > Review request for Aurora, George Sirois, Joshua Cohen, John Sirois, and > Brian Wickman. > > > Bugs: AURORA-1014 > https://issues.apache.org/jira/browse/AURORA-1014 > > > Repository: aurora > > > Description > ------- > > Resolve docker tags to concrete identifiers for DockerContainerizer > > Docker tags are mutable and can point to different different images > at different points in time. This makes a job launched with a Docker > image to be mutable across restarts of the job. This breaks Aurora's > guarantee of job immutability (except via job updates). > > This change introduces a binding helper, that resolves docker name:tag > to a concrete registry/name@digest identifier. Identifying > docker images via a content-addressable digest is available via the > Docker Registry v2, that is a prerequisite for this feature. > > > Diffs > ----- > > 3rdparty/python/requirements.txt 2fb6f4c76c0da9f7958f9b161e701eb894125481 > RELEASE-NOTES.md 03349b0b687bade48a2d19712dcb63802f3ef273 > build-support/packer/build.sh f5157a60dcabde3e4cd8f6655f1010771f14b702 > docs/features/containers.md 8af38e3af989351925a4130da1ce7a0f5853f0bf > examples/jobs/hello_docker_engine.aurora > 3c830e8f99f07732ae985b0aad114c3346888765 > src/main/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION > src/main/python/apache/aurora/client/binding_helpers/__init__.py > PRE-CREATION > src/main/python/apache/aurora/client/binding_helpers/docker_helper.py > PRE-CREATION > src/main/python/apache/aurora/client/cli/client.py > fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 > src/main/python/apache/aurora/client/docker/BUILD PRE-CREATION > src/main/python/apache/aurora/client/docker/__init__.py PRE-CREATION > src/main/python/apache/aurora/client/docker/docker_client.py PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/__init__.py > PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/test_docker_helper.py > PRE-CREATION > src/test/python/apache/aurora/client/docker/BUILD PRE-CREATION > src/test/python/apache/aurora/client/docker/__init__.py PRE-CREATION > src/test/python/apache/aurora/client/docker/test_docker_client.py > PRE-CREATION > src/test/python/apache/aurora/config/BUILD > 52b60409e1de2f69f181a83720ebe1c649b49166 > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora > c71fb81490863b44827bf090f6e5a6b28da94b93 > src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora > 4fa387d5184968e456bf4c8388496f0514454cb1 > src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora > b279b4f679cc6843e99806bcbf57350ba1c9a6e0 > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > c93be9b4b4c76186445ae13eb9424bbf9de9b202 > > Diff: https://reviews.apache.org/r/52479/diff/ > > > Testing > ------- > > build-support/jenkins/build.sh > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >
