----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152572 -----------------------------------------------------------
Just a few more comments, overall lgtm! build-support/packer/build.sh (line 64) <https://reviews.apache.org/r/52479/#comment221624> What's the purpose of this restart? build-support/packer/build.sh (line 69) <https://reviews.apache.org/r/52479/#comment221623> I believe this script is running as root, so this will create the directory as `/root/.docker-registry-data`, is that what we want? docs/features/containers.md (line 71) <https://reviews.apache.org/r/52479/#comment221625> "Starting with the 0.17.0 release..." src/main/python/apache/aurora/client/binding_helpers/BUILD (line 15) <https://reviews.apache.org/r/52479/#comment221797> This BUILD file should not exist. See https://github.com/apache/aurora/blob/master/docs/development/thermos.md for a reference to how BUILD files are structured for our python code. src/main/python/apache/aurora/client/docker/BUILD (line 15) <https://reviews.apache.org/r/52479/#comment221798> ditto here re: BUILD file. src/main/python/apache/aurora/client/docker/docker_client.py (line 38) <https://reviews.apache.org/r/52479/#comment221804> I thought we were going to drop the auth stuff? src/main/python/apache/aurora/client/docker/docker_client.py (line 90) <https://reviews.apache.org/r/52479/#comment221808> If we're only using the `Docker-Content-Digest` header from the response and dropping the body on the floor, can we just send a `HEAD` request instead of a full `GET`? src/main/python/apache/aurora/client/docker/docker_client.py (line 99) <https://reviews.apache.org/r/52479/#comment221809> If we do drop auth support, can move this to right after we make the request. src/test/python/apache/aurora/client/binding_helpers/BUILD (line 15) <https://reviews.apache.org/r/52479/#comment221805> Same here, re: BUILD src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (line 542) <https://reviews.apache.org/r/52479/#comment221810> I'd say just use the binding helper as the default for the docker containerizer test case rather than re-running all the tests again just to test the binding helper. - Joshua Cohen On Oct. 13, 2016, 4:41 a.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52479/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 4:41 a.m.) > > > Review request for Aurora, George Sirois, Joshua Cohen, John Sirois, and > Brian Wickman. > > > Bugs: AURORA-1014 > https://issues.apache.org/jira/browse/AURORA-1014 > > > Repository: aurora > > > Description > ------- > > Resolve docker tags to concrete identifiers for DockerContainerizer > > Docker tags are mutable and can point to different different images > at different points in time. This makes a job launched with a Docker > image to be mutable across restarts of the job. This breaks Aurora's > guarantee of job immutability (except via job updates). > > This change introduces a binding helper, that resolves docker name:tag > to a concrete registry/name@digest identifier. Identifying > docker images via a content-addressable digest is available via the > Docker Registry v2, that is a prerequisite for this feature. > > > Diffs > ----- > > 3rdparty/python/requirements.txt 2fb6f4c76c0da9f7958f9b161e701eb894125481 > RELEASE-NOTES.md 03349b0b687bade48a2d19712dcb63802f3ef273 > build-support/packer/build.sh f5157a60dcabde3e4cd8f6655f1010771f14b702 > docs/features/containers.md 8af38e3af989351925a4130da1ce7a0f5853f0bf > examples/jobs/hello_docker_engine.aurora > 3c830e8f99f07732ae985b0aad114c3346888765 > src/main/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION > src/main/python/apache/aurora/client/binding_helpers/__init__.py > PRE-CREATION > src/main/python/apache/aurora/client/binding_helpers/docker_helper.py > PRE-CREATION > src/main/python/apache/aurora/client/cli/client.py > fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 > src/main/python/apache/aurora/client/docker/BUILD PRE-CREATION > src/main/python/apache/aurora/client/docker/__init__.py PRE-CREATION > src/main/python/apache/aurora/client/docker/docker_client.py PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/__init__.py > PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/test_docker_helper.py > PRE-CREATION > src/test/python/apache/aurora/client/docker/BUILD PRE-CREATION > src/test/python/apache/aurora/client/docker/__init__.py PRE-CREATION > src/test/python/apache/aurora/client/docker/test_docker_client.py > PRE-CREATION > src/test/python/apache/aurora/config/BUILD > 52b60409e1de2f69f181a83720ebe1c649b49166 > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora > c71fb81490863b44827bf090f6e5a6b28da94b93 > src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora > 4fa387d5184968e456bf4c8388496f0514454cb1 > src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora > b279b4f679cc6843e99806bcbf57350ba1c9a6e0 > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > c93be9b4b4c76186445ae13eb9424bbf9de9b202 > > Diff: https://reviews.apache.org/r/52479/diff/ > > > Testing > ------- > > build-support/jenkins/build.sh > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >
