> On Oct. 17, 2016, 5:05 a.m., Stephan Erb wrote: > > docs/features/containers.md, line 120 > > <https://reviews.apache.org/r/52479/diff/6/?file=1533866#file1533866line120> > > > > Please also mention this field in > > https://github.com/apache/aurora/blob/master/docs/reference/client-cluster-configuration.md
Done. > On Oct. 17, 2016, 5:05 a.m., Stephan Erb wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, lines 446-454 > > <https://reviews.apache.org/r/52479/diff/6/?file=1533885#file1533885line446> > > > > If I remember our vagrant setup correctly, then: > > > > * images are not downloaded from a registry but fetched from a local > > folder > > * the examples in `docs/features/containers.md` and > > `examples/jobs/hello_docker_engine.aurora` are broken because they try to > > fetch an image from the internet which cannot be found in the local folder > > with Docker images. > > > > In addition, this code seems to indicate that: > > > > * the registry will only used for the sha lookup > > * the clusters json is modified even though there would be no harm in > > keeping the registry defined all the time > > > > Correct? > > > > Is it possible that the registry acts as a transparent cache so that > > local and remote images can be found? This would help to streamline the > > issues mentioned above. What you mentioned is true for `MesosContainerizer`. `DockerContainerizer` uses the `docker` engine+daemon and hence it can resolve `aurora.local:5000/http_example:latest` as the image from the local docker registry and will just work. But you are correct, when Mesos has support for pulling Docker image via digest, we will need to configure `/etc/mesos-slave/docker_registry` to point to `aurora.local:5000` instead of `/tmp/mesos/images/docker`. - Santhosh Kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152853 ----------------------------------------------------------- On Oct. 12, 2016, 9:41 p.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52479/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 9:41 p.m.) > > > Review request for Aurora, George Sirois, Joshua Cohen, John Sirois, and > Brian Wickman. > > > Bugs: AURORA-1014 > https://issues.apache.org/jira/browse/AURORA-1014 > > > Repository: aurora > > > Description > ------- > > Resolve docker tags to concrete identifiers for DockerContainerizer > > Docker tags are mutable and can point to different different images > at different points in time. This makes a job launched with a Docker > image to be mutable across restarts of the job. This breaks Aurora's > guarantee of job immutability (except via job updates). > > This change introduces a binding helper, that resolves docker name:tag > to a concrete registry/name@digest identifier. Identifying > docker images via a content-addressable digest is available via the > Docker Registry v2, that is a prerequisite for this feature. > > > Diffs > ----- > > 3rdparty/python/requirements.txt 2fb6f4c76c0da9f7958f9b161e701eb894125481 > RELEASE-NOTES.md 03349b0b687bade48a2d19712dcb63802f3ef273 > build-support/packer/build.sh f5157a60dcabde3e4cd8f6655f1010771f14b702 > docs/features/containers.md 8af38e3af989351925a4130da1ce7a0f5853f0bf > examples/jobs/hello_docker_engine.aurora > 3c830e8f99f07732ae985b0aad114c3346888765 > src/main/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION > src/main/python/apache/aurora/client/binding_helpers/__init__.py > PRE-CREATION > src/main/python/apache/aurora/client/binding_helpers/docker_helper.py > PRE-CREATION > src/main/python/apache/aurora/client/cli/client.py > fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 > src/main/python/apache/aurora/client/docker/BUILD PRE-CREATION > src/main/python/apache/aurora/client/docker/__init__.py PRE-CREATION > src/main/python/apache/aurora/client/docker/docker_client.py PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/__init__.py > PRE-CREATION > src/test/python/apache/aurora/client/binding_helpers/test_docker_helper.py > PRE-CREATION > src/test/python/apache/aurora/client/docker/BUILD PRE-CREATION > src/test/python/apache/aurora/client/docker/__init__.py PRE-CREATION > src/test/python/apache/aurora/client/docker/test_docker_client.py > PRE-CREATION > src/test/python/apache/aurora/config/BUILD > 52b60409e1de2f69f181a83720ebe1c649b49166 > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora > c71fb81490863b44827bf090f6e5a6b28da94b93 > src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora > 4fa387d5184968e456bf4c8388496f0514454cb1 > src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora > b279b4f679cc6843e99806bcbf57350ba1c9a6e0 > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > c93be9b4b4c76186445ae13eb9424bbf9de9b202 > > Diff: https://reviews.apache.org/r/52479/diff/ > > > Testing > ------- > > build-support/jenkins/build.sh > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >
