-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54106/#review156975
-----------------------------------------------------------
Master (d56f8c6) is red with this patch.
./build-support/jenkins/build.sh
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java:179:14:
error: Unnecessary parentheses around return value.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java:17:
error: Wrong order for 'java.util.List' import. Order should be: java, javax,
scala, com, net, org. Each group should be separated by a single blank
line.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java:48:53:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java:50:18:
error: Assignment of parameter 'percentile' is not allowed.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:1:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:1:
error: Line does not match expected header line of '^\/\*\*$'.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:4:8:
error: Unused import - java.util.Arrays.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:16:8:
error: Unused import - org.apache.aurora.common.stats.StatsProvider.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:35:13:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:39:55:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:40:16:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:43:45:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:44:16:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:46:93:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:47:
error: '}' have incorrect indentation level 0, expected level should be 4.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:47:2:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:78:9:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:88:50:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:88:72:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:92:
error: File contains a sequence of empty lines.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 12.899 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Nov. 27, 2016, 10:20 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54106/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2016, 10:20 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Santhosh Kumar
> Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> __Modification to SlaUtil::percentile to compute percentiles by
> interpolation__
>
> The calculation of mttX (median-time-to-X) depends on the computation of
> percentile values. The current implementation does not behave nicely with a
> small sample size. For instance, for a given sample set of {50, 150},
> 50-percentile is reported to be 50. Although, 100 seems a more appropriate
> return value.
>
> This patch uses Guava's Quantile for interpolation.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java
> 263647e802b664fd3ea21cef8109fb7a9252356f
> src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java
> 156b9c0a2fa0c0ec4b7220d5ec2cc40c3e59d1d6
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java
> e7287cec28e7b8ca978c506bfe821f261bc0ac26
>
> src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java
> PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java
> eca1beebc906d3354d8c294ba466bc904bde98fa
>
> src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java
> PRE-CREATION
>
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java
> 2e560c0d565689703b282391fe49dbf213ee25dc
>
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java
> 79999e19454568540c14f91808635bf8dff82bb3
>
> Diff: https://reviews.apache.org/r/54106/diff/
>
>
> Testing
> -------
>
> Tests added and modified to match the continuous distribution.
> I also exported the tests into excel and check the reports percentiles.
>
>
> Thanks,
>
> Reza Motamedi
>
>
