----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54106/#review157200 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java (lines 55 - 57) <https://reviews.apache.org/r/54106/#comment227656> just return the above statement directly, no need for the intermediate var. src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java (lines 51 - 61) <https://reviews.apache.org/r/54106/#comment227657> This test should move in to a new SlaUtilTest class, rather than piggybacking on SlaAlgorithmTest - Joshua Cohen On Nov. 29, 2016, 12:17 a.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54106/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 12:17 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Santhosh Kumar > Shanmugham. > > > Repository: aurora > > > Description > ------- > > __Modification to SlaUtil::percentile to compute percentiles by > interpolation__ > > The calculation of mttX (median-time-to-X) depends on the computation of > percentile values. The current implementation does not behave nicely with a > small sample size. For instance, for a given sample set of {50, 150}, > 50-percentile is reported to be 50. Although, 100 seems a more appropriate > return value. > > This patch uses Guava's Quantile for interpolation. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java > 263647e802b664fd3ea21cef8109fb7a9252356f > src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java > 156b9c0a2fa0c0ec4b7220d5ec2cc40c3e59d1d6 > src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java > eca1beebc906d3354d8c294ba466bc904bde98fa > > Diff: https://reviews.apache.org/r/54106/diff/ > > > Testing > ------- > > Tests added and modified to match the continuous distribution. > I also exported the tests into excel and check the reports percentiles. > > > Thanks, > > Reza Motamedi > >
