-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54754/#review159175
-----------------------------------------------------------
Master (220e23b) is red with this patch.
./build-support/jenkins/build.sh
Note: Recompile with -Xlint:unchecked for details.
:commons-args:compileJava
:commons-args:processResources
:commons-args:classes
:commons-args:jar
:commons:compileJavaNote: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.1
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
Note: Wrote forwarder
org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java:176:
error: exception TaskDescriptionException is never thrown in body of
corresponding try statement
} catch (ConfigurationManager.TaskDescriptionException | CronException e)
{
^
1 error
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 2.831 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 14, 2016, 5:01 p.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54754/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 5:01 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1684
> https://issues.apache.org/jira/browse/AURORA-1684
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixed starting cron jobs when using default_docker_parameters
>
> The code was previously attempting to re-sanitize the configuration read from
> storage rather than just using it as is. This causes issues if after
> sanitization the job no longer passes sanitization (which is the case here w/
> default_docker_parameters).
>
> We've been running this in our branch forever.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java
> c07551e94f9221b5b21c5dc9715e82caa290c2e8
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java
> 650facecc2e02be7bb3cd5ea9ff0f094e006bcb3
>
> Diff: https://reviews.apache.org/r/54754/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Niemitz
>
>
