----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54754/#review159198 -----------------------------------------------------------
Ship it! Master (220e23b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 14, 2016, 6:01 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54754/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2016, 6:01 p.m.) > > > Review request for Aurora. > > > Bugs: AURORA-1684 > https://issues.apache.org/jira/browse/AURORA-1684 > > > Repository: aurora > > > Description > ------- > > Fixed starting cron jobs when using default_docker_parameters > > The code was previously attempting to re-sanitize the configuration read from > storage rather than just using it as is. This causes issues if after > sanitization the job no longer passes sanitization (which is the case here w/ > default_docker_parameters). > > We've been running this in our branch forever. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java > 5873983479c39a011eb363f7fd442867f0794b17 > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java > 650facecc2e02be7bb3cd5ea9ff0f094e006bcb3 > > src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java > fb06c282c4e94639c521658682c5da3e4dd4baf7 > > Diff: https://reviews.apache.org/r/54754/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
