-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54774/#review159333
-----------------------------------------------------------
Master (220e23b) is red with this patch.
./build-support/jenkins/build.sh
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
Note: Wrote forwarder
org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java:20:8:
Unused import - com.google.common.collect.ImmutableSet. [UnusedImports]
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java:88:42:
'{' is not followed by whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java:97:44:
'{' is not followed by whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java:33:8:
Unused import - com.google.common.annotations.VisibleForTesting.
[UnusedImports]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 15.608 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 15, 2016, 6:01 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54774/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 6:01 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and
> Zameer Manji.
>
>
> Bugs: AURORA-1861
> https://issues.apache.org/jira/browse/AURORA-1861
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Motivation: Thanks to the mybatis query metrics we added, we found that
> double writing Snapshot fields for H2 stores adds considerable overhead to
> our snapshot creation time.
>
> Snapshots are also written as backups, and many operators choose to process
> backups offline for analytics, rather than query the live scheduler (due to
> not being able to scale reads horizontally). So this allows operators to
> enable/disable the hydrated fields as needed.
>
>
> Diffs
> -----
>
>
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
> 3fa408e283f91b313633959ea6d2e730d4dc0771
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java
> 7dcd1bfcf303cf374e9a6627cb6c632ccea098f2
>
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
> d2c859055f905ac76ee8eb387dca103b9857ddbe
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java
> 7a11850e217dcb0148e4a4d33542c95b2e53a726
>
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java
> cf0a8f3ea11e9c48d1f16441af54dc781b33bdfc
>
> Diff: https://reviews.apache.org/r/54774/diff/
>
>
> Testing
> -------
>
> ./gradlew test
>
> I'll apply this to one of our test clusters before merging to master too.
>
>
> Thanks,
>
> David McLaughlin
>
>
