> On Dec. 15, 2016, 2:15 p.m., Stephan Erb wrote: > > I would like to understand your thinking here: Why add so many todos if the > > necessary code change itself is rather small. Do you expect there is a > > certain risk here?
Updated description to match information I added to the JIRA. The TODOs are also now gone. Please let me know if it's still not clear why we can't just remove these duplicate fields. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54774/#review159292 ----------------------------------------------------------- On Dec. 15, 2016, 6:01 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54774/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 6:01 p.m.) > > > Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and > Zameer Manji. > > > Bugs: AURORA-1861 > https://issues.apache.org/jira/browse/AURORA-1861 > > > Repository: aurora > > > Description > ------- > > Motivation: Thanks to the mybatis query metrics we added, we found that > double writing Snapshot fields for H2 stores adds considerable overhead to > our snapshot creation time. > > Snapshots are also written as backups, and many operators choose to process > backups offline for analytics, rather than query the live scheduler (due to > not being able to scale reads horizontally). So this allows operators to > enable/disable the hydrated fields as needed. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > 3fa408e283f91b313633959ea6d2e730d4dc0771 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java > 7dcd1bfcf303cf374e9a6627cb6c632ccea098f2 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > d2c859055f905ac76ee8eb387dca103b9857ddbe > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > 7a11850e217dcb0148e4a4d33542c95b2e53a726 > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java > cf0a8f3ea11e9c48d1f16441af54dc781b33bdfc > > Diff: https://reviews.apache.org/r/54774/diff/ > > > Testing > ------- > > ./gradlew test > > I'll apply this to one of our test clusters before merging to master too. > > > Thanks, > > David McLaughlin > >
