----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review160546 -----------------------------------------------------------
I was going to wrap this up - but how do people feel about making the all endpoints "idempotent" by the following method ? Inlcude an "idempotency-token" along as part of the HTTP header. This token is locally cached for, say, an hour. Every request with the same token will return simply short circuit and not be processed. The retry logic to transport layer so that we can transparently add the idempotency tokens. - Karthik Anantha Padmanabhan On Dec. 22, 2016, 12:06 a.m., Karthik Anantha Padmanabhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54957/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 12:06 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, Santhosh Kumar > Shanmugham, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This diff adds an option to not retry api calls to the scheduler. For some of > the non-idempotent operations we would like to not automatically retry. This > patch makes this functionality available only to the `schedule_backup_now` > command. > > If there is consensus, this can be added to all commands as well. > > > Diffs > ----- > > src/main/python/apache/aurora/admin/admin.py > 070c348d2ca5db1edecf832efd9aa5481bddaa4b > src/main/python/apache/aurora/admin/aurora_admin.py > fbebbab8c827b5695042d18770d850e31fc38122 > src/main/python/apache/aurora/client/api/__init__.py > e1dde638bd1d686269fbcd88cb083a52e7f5dbfc > src/main/python/apache/aurora/client/api/scheduler_client.py > 9bbfece012e48e0b1752bbefd25c89e04d312cf6 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef > > Diff: https://reviews.apache.org/r/54957/diff/ > > > Testing > ------- > > * Manuall testing > * ./build-support/jenkins/build.sh passes > > > Thanks, > > Karthik Anantha Padmanabhan > >
