-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54957/#review169847
-----------------------------------------------------------
Master (33acb89) is red with this patch.
./build-support/jenkins/build.sh
(To run a reporting server: ./pants server)
08:38:11 00:00 [setup]
08:38:11 00:00 [parse][32m
Executing tasks in goals: compile[0m
08:38:11 00:00 [compile]
08:38:11 00:00 [compile-prep-command]
08:38:11 00:00 [prep_command]
08:38:14 00:03 [compile]
08:38:14 00:03 [python-eval]
08:38:14 00:03 [pythonstyle]
08:38:14 00:03 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
T302:ERROR
src/test/python/apache/aurora/client/api/test_scheduler_client.py:059 Expected
2 blank lines, found 1
|def test_coverage():
T301:ERROR
src/test/python/apache/aurora/client/api/test_scheduler_client.py:598-599
Expected 1 blank lines, found 2
| @mock.patch('apache.aurora.client.api.scheduler_client.SchedulerClient',
| spec=scheduler_client.SchedulerClient)
E302:ERROR
PythonFile(src/test/python/apache/aurora/client/api/test_scheduler_client.py):059
expected 2 blank lines, found 1
|def test_coverage():
E303:ERROR
PythonFile(src/test/python/apache/aurora/client/api/test_scheduler_client.py):598-599
too many blank lines (2)
| @mock.patch('apache.aurora.client.api.scheduler_client.SchedulerClient',
| spec=scheduler_client.SchedulerClient)
T302:ERROR src/main/python/apache/aurora/admin/aurora_admin.py:050 Expected 2
blank lines, found 1
|def proxy_main():
E302:ERROR
PythonFile(src/main/python/apache/aurora/admin/aurora_admin.py):050 expected 2
blank lines, found 1
|def proxy_main():
FAILURE: 6 Python Style issues found. For import order related issues, please
try `./pants fmt.isort <targets>`
08:38:39 00:28 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 23, 2017, 8:23 a.m., Karthik Anantha Padmanabhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54957/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 8:23 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, Santhosh Kumar
> Shanmugham, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This diff adds an option to not retry api calls to the scheduler. For some of
> the non-idempotent operations we would like to not automatically retry. This
> patch makes this functionality available only to the `schedule_backup_now`
> command.
>
> If there is consensus, this can be added to all commands as well.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/admin.py
> 070c348d2ca5db1edecf832efd9aa5481bddaa4b
> src/main/python/apache/aurora/admin/aurora_admin.py
> fbebbab8c827b5695042d18770d850e31fc38122
> src/main/python/apache/aurora/client/api/__init__.py
> e1dde638bd1d686269fbcd88cb083a52e7f5dbfc
> src/main/python/apache/aurora/client/api/scheduler_client.py
> 9bbfece012e48e0b1752bbefd25c89e04d312cf6
> src/test/python/apache/aurora/client/api/test_scheduler_client.py
> f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef
>
>
> Diff: https://reviews.apache.org/r/54957/diff/3/
>
>
> Testing
> -------
>
> * Manual testing
> * ./build-support/jenkins/build.sh passes
>
>
> Thanks,
>
> Karthik Anantha Padmanabhan
>
>
