----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review160933 -----------------------------------------------------------
src/main/python/apache/aurora/executor/common/sandbox.py (lines 284 - 289) <https://reviews.apache.org/r/55347/#comment232177> This looks suspicious. Creating a directory and then checking it does not exist. src/test/python/apache/aurora/executor/common/test_sandbox.py (lines 404 - 410) <https://reviews.apache.org/r/55347/#comment232168> With that amount of mocking the test is both hard to understand and brittle to changes of the production code. Have you considered extending this https://github.com/apache/aurora/blob/master/examples/vagrant/upstart/aurora-scheduler.conf#L43 list instead? - Stephan Erb On Jan. 9, 2017, 6:38 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55347/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 6:38 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > When testing filesystem isolation internally, we ran into an issue where > mounting a regular file into the task filesystem failed with exit code 32 > since the mount destination did not exist. To account for this, we'll touch > an empty file in the taskfs. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/sandbox.py > 9d6e73c4221302c56596ef3591bdeab41c81535e > src/test/python/apache/aurora/executor/common/test_sandbox.py > a441d2a60e413395b74b62445846e3871784e729 > > Diff: https://reviews.apache.org/r/55347/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Joshua Cohen > >
