> On Jan. 9, 2017, 10:57 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, lines 285-291 > > <https://reviews.apache.org/r/55347/diff/1/?file=1600157#file1600157line285> > > > > I tried a `mkdir` followed by `touch` and the path still continues to > > be a directory. Following this the mount actually fails. > > > > > > $ touch source > > $ mkdir dest > > $ touch dest/ > > > > $ ls -lrth > > total 4.0K > > -rw-r--r-- 1 sshanmugham employee 0 Jan 9 22:52 source > > drwxr-xr-x 2 sshanmugham employee 4.0K Jan 9 22:52 dest > > > > $ sudo mount -n --rbind source dest > > mount: Not a directory > > > > $ echo $? > > 32
Yeah, this is a bug Stephan caught above, introduced when I cleaned up the internal impl for this patch without paying close attention. Have it fixed locally, just working on an e2e test. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55347/#review160995 ----------------------------------------------------------- On Jan. 9, 2017, 5:38 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55347/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 5:38 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > When testing filesystem isolation internally, we ran into an issue where > mounting a regular file into the task filesystem failed with exit code 32 > since the mount destination did not exist. To account for this, we'll touch > an empty file in the taskfs. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/sandbox.py > 9d6e73c4221302c56596ef3591bdeab41c81535e > src/test/python/apache/aurora/executor/common/test_sandbox.py > a441d2a60e413395b74b62445846e3871784e729 > > Diff: https://reviews.apache.org/r/55347/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Joshua Cohen > >
