> On Feb. 14, 2017, 3:56 p.m., Jason Lai wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 144 > > <https://reviews.apache.org/r/53333/diff/4/?file=1632739#file1632739line144> > > > > Actually according to > > [mesos.proto](https://github.com/apache/mesos/blob/1.1.0/include/mesos/mesos.proto#L2124), > > `volumes` is not part of the `MesosInfo` schema, but instead part of > > `ContainerInfo` that wraps both `DockerInfo` and `MesosInfo`. > > > > Do you intend to add `volumes` to the `Mesos` schema in the Aurora > > land? Or have you thought about maintaining consistency between the Aurora > > schema and its Mesos schema counterpart?
I omitted support for this in the DSL because the API definition and the implementation don't plumb volume mounts to Docker Containers. I am under the impression that DockerContainerizer doesn't support it and I am open to revising the DSL and API if there is demand for it. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53333/#review165597 ----------------------------------------------------------- On Feb. 13, 2017, 6:26 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53333/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 6:26 p.m.) > > > Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Bugs: AURORA-1107 > https://issues.apache.org/jira/browse/AURORA-1107 > > > Repository: aurora > > > Description > ------- > > Enables the client DSL to set per task volume mounts. This also adds a E2E > test that tests per task volume mounting. > > > Diffs > ----- > > RELEASE-NOTES.md 3e9880249aa40215a08424b58f85a634337cc67e > docs/reference/configuration.md 6c7114256ea6f57d6e09e07896e9f4fde19139ca > examples/vagrant/upstart/aurora-scheduler.conf > 91f0f0c18062cb8ca36c104a270b1d16ff13cd52 > src/main/python/apache/aurora/config/schema/base.py > b15b93942f6d92d8f4c84c82d61950414f4f3d34 > src/main/python/apache/aurora/config/thrift.py > 3539469d243638c0acd08bf0859d0ce858d8977c > src/test/python/apache/aurora/config/test_thrift.py > e213184739167e01f3614c20a809af39b3a6b3d6 > src/test/sh/org/apache/aurora/e2e/Dockerfile.netcat > c8b2f46a36d2ddecf030bc7f005afc1f7fe5e99d > src/test/sh/org/apache/aurora/e2e/check-fs.sh PRE-CREATION > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora > b2b977b0c248e7156061653aacec43947cc49cd5 > src/test/sh/org/apache/aurora/e2e/run-server.sh > 1fe09090bfa3eeb0f6897e8c895782fb1ff949a1 > > Diff: https://reviews.apache.org/r/53333/diff/ > > > Testing > ------- > > sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Zameer Manji > >
