----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59039/#review174117 -----------------------------------------------------------
Ship it! Master (85fed6b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 6, 2017, 4:52 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59039/ > ----------------------------------------------------------- > > (Updated May 6, 2017, 4:52 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer > Manji. > > > Bugs: AURORA-1920 > https://issues.apache.org/jira/browse/AURORA-1920 > > > Repository: aurora > > > Description > ------- > > Add the ability to replace the first-fit scheduling algorithm and associated > first-fit preemption logic. > > See design/proposal document here: > https://docs.google.com/document/d/1fVHLt9AF-YbOCVCDMQmi5DATVusn-tqY8DldKbjVEm0/edit?usp=sharing > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterModule.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > 66d20290d381c041ac2f28903d6ba1468b352172 > > src/main/java/org/apache/aurora/scheduler/state/FirstFitTaskAssignerModule.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/state/StateModule.java > 0186484208965c5b8942ec76eb078b30190c7d57 > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java > da064e3589951d4f4cbff96d1ed89d9d7e4d3882 > > > Diff: https://reviews.apache.org/r/59039/diff/1/ > > > Testing > ------- > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Before shipping this, I'm also going to migrate out internal fork of > TaskAssigner over to using this approach to verify everything looks good. > > > Thanks, > > David McLaughlin > >
