-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177284
-----------------------------------------------------------
Master (73234d0) is red with this patch.
./build-support/jenkins/build.sh
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
Note: Wrote forwarder
org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:25:
Wrong order for 'com.google.common.annotations.VisibleForTesting' import.
Order should be: java, javax, scala, com, net, org. Each group should
be separated by a single blank line. [ImportOrder]
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:82:
Line has trailing spaces. [RegexpSingleline]
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:88:39:
'ini' hides a field. [HiddenField]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 23.874 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On June 8, 2017, 8:56 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 8:56 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
> 43c38dcffd8e68c018217681cc5a3073d9fb1437
>
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java
> d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/2/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
