> On June 8, 2017, 7:48 p.m., David McLaughlin wrote: > > Can you give a higher level description of what you're trying to achieve? > > Ruben D. Porras wrote: > Allows to use a custom CredentialsMatchers... > > - using the command line argument **shiro_credentials_matcher** it's > possible to specify which credentials matcher class has to be used in order > to inject and use it as a credential matcher > - in that way, it's possible to use credentials matchers that allows non > plain passwords > > > I've tested it implementing a credential matcher for bcrypt, then include > the library in the classpath and providing the class with the argument > **shiro_credentials_matcher**, so my **shiro.ini** contains bcrypted password.
I understood that part :) I was asking because the (pretty simple) module you've modified is already pluggable in the Scheduler: https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java#L76 - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59883/#review177359 ----------------------------------------------------------- On June 8, 2017, 7:25 a.m., Ruben D. Porras wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59883/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 7:25 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Includes: > - Adding eclipse generated files to .gitignore > - Support specifying a custom ShiroCredentialsMatcher > > > Diffs > ----- > > .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d > > src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java > 43c38dcffd8e68c018217681cc5a3073d9fb1437 > > src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java > d05ecebd6c3c1c6019c150ec449c1e1103222fbb > > > Diff: https://reviews.apache.org/r/59883/diff/5/ > > > Testing > ------- > > Modify unit tests to add constructor parameter > Run Scheduler manually configured to check that still working properly > > > Thanks, > > Ruben D. Porras > >
