-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59733/
-----------------------------------------------------------
(Updated June 12, 2017, 6:37 a.m.)
Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan
Erb, and Zameer Manji.
Changes
-------
Refactored `wait_escalation_time` into two fields for the separate endpoints,
`graceful_shutdown_wait_secs` and `shutdown_wait_secs`.
Refactored the way the terminate cycle works. Previously it would wait the full
escalation time before checking if the process was killed. Now, since the wait
times are configurable and can be longer, we poll every 1 second up to the wait
time in case the process was killed early.
Rewrote tests and documentation.
Tested on Vagrant devcluster, ran unit + integration tests.
Bugs: AURORA-1931
https://issues.apache.org/jira/browse/AURORA-1931
Repository: aurora
Description
-------
We have some services that require more than the current 10 seconds given to
gracefully shutdown (they need to close resources, finish requests, etc).
We would like to be able to configure the amount of time we wait between each
stage of the graceful shutdown sequence. See this
[proposal](https://docs.google.com/document/d/1Sl-KWNyt1j0nIndinqfJsH3pkUY5IYXfGWyLHU2wacs/edit?usp=sharing)
for a more in-depth
analysis.
Diffs (updated)
-----
RELEASE-NOTES.md d14c4ad2a1bbdfdc845f1ec6dcd931c16b94569a
docs/reference/configuration.md 0040de17a85f5820c069474716678c66afce373b
docs/reference/task-lifecycle.md cf1b6794dca92756cee4a54f00f33fd3b1a481ea
src/main/python/apache/aurora/config/schema/base.py
b2692a648645a195a24491e4978fb833c6c20be8
src/main/python/apache/aurora/executor/aurora_executor.py
81461cb49ac223f3bdfa59e8c59e150a07771dea
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
c6c08983fb2d204afedd419798135d667169bce4
src/main/python/apache/aurora/executor/http_lifecycle.py
9280bf29da9bda1691adbf3a4c34c4f3d4900517
src/test/python/apache/aurora/client/cli/test_inspect.py
4a23c5984c2d093e2f53e93aec71418f84b65928
src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py
38deae69dce7d88dab87f70e0128e0b86091fdef
src/test/python/apache/aurora/executor/test_http_lifecycle.py
a967e3410a4d2dc2e1721f505a4d76da9209d177
src/test/python/apache/aurora/executor/test_thermos_executor.py
e628ccd21f0588d0c76001b8f336ffa844c3ec35
src/test/python/apache/aurora/executor/test_thermos_task_runner.py
1b92667bceabc8ea1540122477a51cb58ea2ae36
Diff: https://reviews.apache.org/r/59733/diff/5/
Changes: https://reviews.apache.org/r/59733/diff/4-5/
Testing
-------
Ran unit and integration tests.
Created and killed jobs with varying wait_escalation_secs values on the Vagrant
devcluster.
Thanks,
Jordan Ly
